From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org
Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts
Date: Wed, 03 Jun 2020 14:58:07 +0000 [thread overview]
Message-ID: <87d06g6vsw.fsf@gmail.com> (raw)
In-Reply-To: <83d06gcjtp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Jun 2020 17:20:18 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Pip Cet <pipcet@gmail.com>
>> Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org
>> Date: Tue, 02 Jun 2020 19:21:31 +0000
>>
>> >> xdisp.c:
>> >> 30008 if (get_char_glyph_code (it->char_to_display, font,
>> >> &char2b))
>> >> 30009 {
>> >> 30010 pcm = get_per_char_metric (font, &char2b);
>> >> 30011 if (pcm->width == 0
>> >> 30012 && pcm->rbearing == 0 && pcm->lbearing == 0)
>> >> 30013 pcm = NULL;
>> >> 30014 }
>> >>
>> >
>> > ...with this. I think you are right, and we should do the same with
>> > zero-width LGLYPH_STRING, forcing it->glyph_not_available_p to
>> > non-zero, and then doing something like this in
>> > fill_gstring_glyph_string:
>> >
>> > if (s->font == NULL || glyph_not_available_p)
>> > {
>> > s->font_not_found_p = true;
>> > s->font = FRAME_FONT (s->f);
>> > }
>> >
>> > similar to what fill_glyph_string does. WDYT?
>>
>> I agree; the more I think about it, the more dangerous zero-sized
>> characters seem to me.
>>
>> And almost all of my concerns apply to characters with zero x advance,
>> no matter whether they have lbearing or rbearing > 0.
>
> AFAIU, the advance metric is what we call "pixel width", and if so,
> the above snippet from xdisp.c already tests it. Right?
Some code after it does, yes.
>> Maybe, for master, we should reject those as well? I was going to say
>> "or force their width to be at least a single pixel", but I'm not even
>> sure that's sufficient on hidpi screens...
>>
>> So, in summary, I'd like to do the following:
>>
>> 1. abort if we ever find ourselves drawing a zero-width cursor
>> 2. reject lgstrings of zero width
>> 3. reject all glyphs of zero width outside of compositions
>> 4. allow users to specify a minimum width, perhaps relative to the font
>> size, so they can always see their cursor
>>
>> ...which would be quite a different patch.
>
> I'm not sure I follow. What do you mean by "reject"? I thought the
> code which ignores the metric and sets the font_not_found_p flag when
> we get a zero-width glyph is a kind of "rejection".
I mean "treat the glyph as non-existent". Currently, for (3), glyphs
with lbearing but no pixel width are treated as valid and expanded to
cover a single pixel, which is all but invisible on my screen.
> I like the idea
> of doing that in the case of compositions because that is consistent
> with what we do when we extract the metrics directly from the font.
I do too.
> Are you saying that what we do with simple characters in this case is
> not good enough?
I'm saying it's not good enough for non-spacing characters that actually
do print something: they're displayed as single-pixel-wide glyphs, which
I think is insufficient to let users be aware of them.
> If you disable auto-composition-mode, and use the
> fonts which shows CGJ as zero-width glyph, do you still see display
> artifacts?
No.
> If not, what do you see and why is this kind of
> 'rejection" not enough?
CGJ is displayed as a black box as wide as a space, which is perfectly
fine. It's U+301 that's not.
next prev parent reply other threads:[~2020-06-03 14:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:45 bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 15:29 ` Eli Zaretskii
2020-06-01 15:50 ` Pip Cet
2020-06-01 16:06 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 16:36 ` Eli Zaretskii
2020-06-01 17:44 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 18:27 ` Pip Cet
2020-06-01 16:14 ` Eli Zaretskii
2020-06-01 18:09 ` Pip Cet
2020-06-01 18:37 ` Eli Zaretskii
2020-06-01 19:35 ` Eli Zaretskii
2020-06-01 20:15 ` Pip Cet
2020-06-01 19:48 ` Pip Cet
2020-06-01 22:37 ` Pip Cet
2020-06-02 13:45 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 13:57 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:06 ` Pip Cet
2020-06-02 14:32 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:35 ` Pip Cet
2020-06-02 14:39 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 15:51 ` Eli Zaretskii
2020-06-02 15:59 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 16:07 ` Eli Zaretskii
2020-06-02 19:21 ` Pip Cet
2020-06-02 19:49 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-03 14:20 ` Eli Zaretskii
2020-06-03 14:58 ` Pip Cet [this message]
2020-06-03 15:58 ` Eli Zaretskii
2020-06-03 20:23 ` Pip Cet
2020-06-04 2:36 ` Eli Zaretskii
2020-06-04 6:58 ` Pip Cet
2020-06-04 13:31 ` Eli Zaretskii
[not found] ` <874krq4fd8.fsf@gmail.com>
2020-06-05 7:45 ` Eli Zaretskii
2020-06-05 8:31 ` Pip Cet
2020-06-05 15:54 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-05 17:28 ` Eli Zaretskii
2020-06-02 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d06g6vsw.fsf@gmail.com \
--to=pipcet@gmail.com \
--cc=41645@debbugs.gnu.org \
--cc=dfussner@googlemail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).