* bug#65973: [PATCH] ; send filename, not full path, on EWW form submit
@ 2023-09-14 6:10 daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:47 ` Stefan Kangas
2023-12-02 15:02 ` ozzloy
0 siblings, 2 replies; 4+ messages in thread
From: daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-09-14 6:10 UTC (permalink / raw)
To: 65973; +Cc: daniel watson
[-- Attachment #1: Type: text/plain, Size: 2459 bytes --]
0. in one terminal, run this http server
https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/master/item/server.py
1. in another terminal, run
socat -v tcp-listen:8086,fork tcp:localhost:8085
2. browse to the page with EWW,
M-x eww <ENTER> localhost:8086 <ENTER>
3. put the cursor on the word "Browse" <ENTER>
4. select any file to which you have read access for uploading
5. put cursor on "Submit" <ENTER>
6. observe the full path of the file is sent to the server. this is
visible in both the python output and the socat output.
i'm including the diff inline to make it easier to review without
downloading the attached file.
---
lisp/net/eww.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 4ddda216afc..f28273dcc58 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1849,7 +1849,7 @@ eww-submit
(insert-file-contents file)
(buffer-string)))
(cons "name" name)
- (cons "filename" file))
+ (cons "filename" (file-name-nondirectory file)))
values)))
((equal (plist-get input :type) "submit")
;; We want the values from buttons if we hit a button if
--
2.39.2
In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
cairo version 1.16.0) of 2023-08-03 built on bos03-amd64-031
Repository revision: cf57ec68c2a5ac5b721f445928869ca14232a4d1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Ubuntu 23.04
Configured using:
'configure --prefix=/snap/emacs/current/usr --with-x-toolkit=gtk3
--without-xaw3d --with-modules --with-cairo
--with-native-compilation=aot --with-xinput2 --with-tree-sitter
--with-json
'CFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include
-isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu
-isystem/build/emacs/stage/usr/include -O2'
'CPPFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include
-isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu
-isystem/build/emacs/stage/usr/include'
'LDFLAGS=-L/build/emacs/parts/emacs/install/lib
-L/build/emacs/parts/emacs/install/usr/lib
-L/build/emacs/parts/emacs/install/lib/x86_64-linux-gnu
-L/build/emacs/parts/emacs/install/usr/lib/x86_64-linux-gnu
-L/build/emacs/stage/usr/lib''
[-- Attachment #2: 0001-send-filename-not-full-path-on-EWW-form-submit.patch --]
[-- Type: text/x-diff, Size: 1170 bytes --]
From 7b360d91a6667034da7c682af01ee1008d052c40 Mon Sep 17 00:00:00 2001
From: Daniel Watson <ozzloy@each.do>
Date: Tue, 12 Sep 2023 00:06:14 -0700
Subject: [PATCH] ; send filename, not full path, on EWW form submit
; * lisp/net/eww.el (eww-submit): Instead of sending the entire file
; path, send just the filename and not the directory. This is the
; behavior seen in other clients, such as firefox, chromium, and curl.
; It keeps information about the users directory structure private.
---
lisp/net/eww.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 4ddda216afc..f28273dcc58 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1849,7 +1849,7 @@ eww-submit
(insert-file-contents file)
(buffer-string)))
(cons "name" name)
- (cons "filename" file))
+ (cons "filename" (file-name-nondirectory file)))
values)))
((equal (plist-get input :type) "submit")
;; We want the values from buttons if we hit a button if
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#65973: [PATCH] ; send filename, not full path, on EWW form submit
2023-09-14 6:10 bug#65973: [PATCH] ; send filename, not full path, on EWW form submit daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-09-15 11:47 ` Stefan Kangas
2023-09-19 7:15 ` daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 15:02 ` ozzloy
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2023-09-15 11:47 UTC (permalink / raw)
To: daniel watson; +Cc: 65973, daniel watson
daniel watson <ozzloy@challenge-bot.com> writes:
> i'm including the diff inline to make it easier to review without
> downloading the attached file.
Most (or all?) people reviewing patches use Emacs mail readers, so we
have no trouble reviewing attached files. Getting it as an attachment
actually makes things easier for us, as our tools are adapted to that
workflow. That's the main reason why we have a preference for that
format.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65973: [PATCH] ; send filename, not full path, on EWW form submit
2023-09-15 11:47 ` Stefan Kangas
@ 2023-09-19 7:15 ` daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 4+ messages in thread
From: daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-09-19 7:15 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 65973, daniel watson
On Fri, Sep 15, 2023 at 04:47:08AM -0700, Stefan Kangas wrote:
> Most (or all?) people reviewing patches use Emacs mail readers, so we
> have no trouble reviewing attached files. Getting it as an attachment
> actually makes things easier for us, as our tools are adapted to that
> workflow. That's the main reason why we have a preference for that
> format.
that makes sense. i want to get my email setup like that.
the inline patch was included for easier viewing in the browser and not
as a replacement for the attachment, or endorsing skipping the
attachment. so i'm glad you clarified
on the last bug report, when i got help from people, i found myself
linking to both the bug report page, and separately to another page
where they could view the code in-browser. maybe the bug report page
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65973
could display the attached patch in addition to having a download link.
the source code for this page has not been touched in years though, so
that makes me think it will be difficult to contribute a change.
thanks for the assistance with this and the prior bug!
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65973: [PATCH] ; send filename, not full path, on EWW form submit
2023-09-14 6:10 bug#65973: [PATCH] ; send filename, not full path, on EWW form submit daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:47 ` Stefan Kangas
@ 2023-12-02 15:02 ` ozzloy
1 sibling, 0 replies; 4+ messages in thread
From: ozzloy @ 2023-12-02 15:02 UTC (permalink / raw)
To: daniel watson; +Cc: 65973
[-- Attachment #1: Type: text/plain, Size: 2749 bytes --]
bump
On Wed, Sep 13, 2023 at 11:10 PM daniel watson <ozzloy@challenge-bot.com>
wrote:
>
> 0. in one terminal, run this http server
> https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/master/item/server.py
> 1. in another terminal, run
> socat -v tcp-listen:8086,fork tcp:localhost:8085
> 2. browse to the page with EWW,
> M-x eww <ENTER> localhost:8086 <ENTER>
> 3. put the cursor on the word "Browse" <ENTER>
> 4. select any file to which you have read access for uploading
> 5. put cursor on "Submit" <ENTER>
> 6. observe the full path of the file is sent to the server. this is
> visible in both the python output and the socat output.
>
> i'm including the diff inline to make it easier to review without
> downloading the attached file.
>
> ---
> lisp/net/eww.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 4ddda216afc..f28273dcc58 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -1849,7 +1849,7 @@ eww-submit
> (insert-file-contents file)
> (buffer-string)))
> (cons "name" name)
> - (cons "filename" file))
> + (cons "filename" (file-name-nondirectory file)))
> values)))
> ((equal (plist-get input :type) "submit")
> ;; We want the values from buttons if we hit a button if
> --
> 2.39.2
>
>
>
>
> In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0) of 2023-08-03 built on bos03-amd64-031
> Repository revision: cf57ec68c2a5ac5b721f445928869ca14232a4d1
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
> System Description: Ubuntu 23.04
>
> Configured using:
> 'configure --prefix=/snap/emacs/current/usr --with-x-toolkit=gtk3
> --without-xaw3d --with-modules --with-cairo
> --with-native-compilation=aot --with-xinput2 --with-tree-sitter
> --with-json
> 'CFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include
> -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu
> -isystem/build/emacs/stage/usr/include -O2'
> 'CPPFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include
> -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu
> -isystem/build/emacs/stage/usr/include'
> 'LDFLAGS=-L/build/emacs/parts/emacs/install/lib
> -L/build/emacs/parts/emacs/install/usr/lib
> -L/build/emacs/parts/emacs/install/lib/x86_64-linux-gnu
> -L/build/emacs/parts/emacs/install/usr/lib/x86_64-linux-gnu
> -L/build/emacs/stage/usr/lib''
>
>
>
[-- Attachment #2: Type: text/html, Size: 3539 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-02 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 6:10 bug#65973: [PATCH] ; send filename, not full path, on EWW form submit daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:47 ` Stefan Kangas
2023-09-19 7:15 ` daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 15:02 ` ozzloy
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).