From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
26624@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#26624: 26.0.50; Generalized variable `buffer-local-value' does't restore local flag
Date: Fri, 29 Dec 2017 16:20:49 +0000 [thread overview]
Message-ID: <CAArVCkR-HqoXZ5+xSDmUhkaO9eXMEW4ZE_XOdf5_u+745kg6Ag@mail.gmail.com> (raw)
In-Reply-To: <83o9mhfr4w.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Fr., 29. Dez. 2017 um 17:15 Uhr:
> > From: Michael Heerdegen <michael_heerdegen@web.de>
> > Cc: p.stephani2@gmail.com, 26624@debbugs.gnu.org,
> npostavs@users.sourceforge.net
> > Date: Fri, 29 Dec 2017 15:08:41 +0100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > Does this warning pop up during bootstrap, and if so, how many times?
> >
> > It currently would pop up five times:
> >
> > | ../lisp/electric.el:Warning: Warning: obsolete gv-setter:
> ‘buffer-local-value’
> > | --------------------
> > | ../lisp/electric.el:Warning: Warning: obsolete gv-setter:
> ‘buffer-local-value’
> > | --------------------
> > | electric.el:350:40:Warning: Warning: obsolete gv-setter:
> ‘buffer-local-value’
> > | --------------------
> > | electric.el:580:39:Warning: Warning: obsolete gv-setter:
> ‘buffer-local-value’
> > | --------------------
> > | elec-pair.el:608:38:Warning: Warning: obsolete gv-setter:
> ‘buffer-local-value’
> >
> >
> > Yes, these would need to be treated.
>
> Can we treat them as part of fixing this issue?
>
Yes, but I think changing them should be a separate commit because it's not
straightforward.
These are all modes that can be locally or globally enabled. I think
typically such modes would be defined using `define-minor-mode` and
`define-globalized-minor-mode`, but the electric modes are defined the
other way round, i.e. the main modes are global, and then there are local
modes that use `buffer-local-value` as mode variable. I'd suggest to turn
this around to use `define-minor-mode` for the local modes and
`define-globalized-minor-mode` for the global ones. Would that have any
downsides?
[-- Attachment #2: Type: text/html, Size: 2418 bytes --]
next prev parent reply other threads:[~2017-12-29 16:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 17:13 bug#26624: 26.0.50; Generalized variable `buffer-local-value' does't restore local flag Philipp Stephani
2017-06-17 13:10 ` Philipp Stephani
2017-06-17 18:48 ` npostavs
2017-06-18 4:17 ` Michael Heerdegen
2017-07-02 16:53 ` Philipp Stephani
2017-09-24 15:19 ` Philipp Stephani
2017-09-24 15:36 ` Michael Heerdegen
2017-09-24 15:44 ` Noam Postavsky
2017-09-24 16:42 ` Philipp Stephani
2017-09-24 17:43 ` Noam Postavsky
2017-09-29 7:50 ` Eli Zaretskii
2017-09-29 20:55 ` Philipp Stephani
2017-09-30 6:46 ` Eli Zaretskii
2017-12-26 22:19 ` Michael Heerdegen
2017-12-27 16:10 ` Eli Zaretskii
2017-12-27 19:54 ` Michael Heerdegen
2017-12-27 20:27 ` Eli Zaretskii
2017-12-29 14:08 ` Michael Heerdegen
2017-12-29 16:14 ` Eli Zaretskii
2017-12-29 16:20 ` Philipp Stephani [this message]
2022-08-21 21:38 ` Lars Ingebrigtsen
2022-08-21 22:21 ` Lars Ingebrigtsen
2022-08-22 6:53 ` Michael Heerdegen
2022-08-22 10:10 ` Lars Ingebrigtsen
2022-08-22 21:43 ` Michael Heerdegen
2022-08-23 10:28 ` Lars Ingebrigtsen
2018-01-24 14:33 ` Michael Heerdegen
2018-02-04 19:01 ` Philipp Stephani
2018-02-04 21:02 ` Michael Heerdegen
2018-02-11 17:54 ` Philipp Stephani
2018-02-11 20:56 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkR-HqoXZ5+xSDmUhkaO9eXMEW4ZE_XOdf5_u+745kg6Ag@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=26624@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).