From: Michael Heerdegen <michael_heerdegen@web.de>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 26624@debbugs.gnu.org
Subject: bug#26624: 26.0.50; Generalized variable `buffer-local-value' does't restore local flag
Date: Sun, 11 Feb 2018 21:56:47 +0100 [thread overview]
Message-ID: <878tbz6y9c.fsf@web.de> (raw)
In-Reply-To: <CAArVCkSK8bcxWgTHN6b6i9G1uZO5yzX5MwBUzmj2wsAk2ucyQQ@mail.gmail.com> (Philipp Stephani's message of "Sun, 11 Feb 2018 17:54:02 +0000")
Philipp Stephani <p.stephani2@gmail.com> writes:
> it should rather expand to
>
> (let ((old-state (internal-get-state place)))
> (setf place val)
> (unwind-protect body
> (internal-reset-state place old-state)))
>
> with suitably defined `internal-get-state` and
> `internal-reset-state`. For most use cases `internal-get-state` and
> `internal-reset-state` could just be `identity` and `setf `, but for
> the cases discussed here they would contain additional information.
Is that even well-defined? What happens when the code inside `letf'
also alters this state?
For example, code like
#+begin_src emacs-lisp
(let ((my-alist '((x 1))))
(cl-letf (((alist-get 'y my-alist) 2))
(push (cons 'y 17) my-alist))
my-alist)
#+end_src
or
#+begin_src emacs-lisp
(cl-letf (((buffer-local-value 'x my-buffer) 20))
...
(with-current-buffer my-buffer
(set (make-local-variable 'x) 0))
...)
#+end_src
what would "reset the state" mean?
Michael.
prev parent reply other threads:[~2018-02-11 20:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 17:13 bug#26624: 26.0.50; Generalized variable `buffer-local-value' does't restore local flag Philipp Stephani
2017-06-17 13:10 ` Philipp Stephani
2017-06-17 18:48 ` npostavs
2017-06-18 4:17 ` Michael Heerdegen
2017-07-02 16:53 ` Philipp Stephani
2017-09-24 15:19 ` Philipp Stephani
2017-09-24 15:36 ` Michael Heerdegen
2017-09-24 15:44 ` Noam Postavsky
2017-09-24 16:42 ` Philipp Stephani
2017-09-24 17:43 ` Noam Postavsky
2017-09-29 7:50 ` Eli Zaretskii
2017-09-29 20:55 ` Philipp Stephani
2017-09-30 6:46 ` Eli Zaretskii
2017-12-26 22:19 ` Michael Heerdegen
2017-12-27 16:10 ` Eli Zaretskii
2017-12-27 19:54 ` Michael Heerdegen
2017-12-27 20:27 ` Eli Zaretskii
2017-12-29 14:08 ` Michael Heerdegen
2017-12-29 16:14 ` Eli Zaretskii
2017-12-29 16:20 ` Philipp Stephani
2022-08-21 21:38 ` Lars Ingebrigtsen
2022-08-21 22:21 ` Lars Ingebrigtsen
2022-08-22 6:53 ` Michael Heerdegen
2022-08-22 10:10 ` Lars Ingebrigtsen
2022-08-22 21:43 ` Michael Heerdegen
2022-08-23 10:28 ` Lars Ingebrigtsen
2018-01-24 14:33 ` Michael Heerdegen
2018-02-04 19:01 ` Philipp Stephani
2018-02-04 21:02 ` Michael Heerdegen
2018-02-11 17:54 ` Philipp Stephani
2018-02-11 20:56 ` Michael Heerdegen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tbz6y9c.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=26624@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).