From: Philipp Stephani <p.stephani2@gmail.com>
To: Michael Mauger <mmauger@protonmail.com>
Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>
Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27
Date: Sun, 9 Aug 2020 11:14:24 +0200 [thread overview]
Message-ID: <CAArVCkQJ2vmeA=4PHj_UxquKNRZzLQ3L=JAbHrMOvehu83r+hA@mail.gmail.com> (raw)
In-Reply-To: <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com>
Am So., 9. Aug. 2020 um 04:14 Uhr schrieb Michael Mauger
<mmauger@protonmail.com>:
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani <p.stephani2@gmail.com> wrote:
>
> > Am Mo., 23. März 2020 um 02:20 Uhr schrieb Michael Mauger
> > mmauger@protonmail.com:
> >
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz@gnu.org wrote:
> > >
> > > > Ping!
> > > >
> > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200
> > > > > From: Eli Zaretskii eliz@gnu.org
> > > > > Cc: 39960@debbugs.gnu.org
> > > > >
> > > > > > From: Philipp p.stephani2@gmail.com
> > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100
> > > > > > In Emacs 26, sql-add-product has the signature
> > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST)
> > > > > > However, in the Emacs 27 pretest the signature is now
> > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST)
> > > > > > Note the change from &rest to &optional. This is a breaking change that
> > > > > > breaks all users of sql-add-product. I've found quite a few uses of the
> > > > > > old signature in the wild,
> > > > >
> > > > > Thanks for reporting this.
> > > > > Michael, could you please look into this ASAP? TIA.
> > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide
> > > > > eventually on keeping the change, we should announce it in NEWS.
> > >
> > > Sorry for the delay. The massive switch to WFH and illness concerns at home
> > > interfered. All are fine, and I actually do get work done occasionally.
> >
> > No worries, and good to hear that!
> >
> > > I've got the following patch to make. I assume it needs to be made to the
> > > emacs-27 branch and corresponding patches made to master as well. If I
> > > should only commit to master (same change is needed there) for cherry-picking
> > > for emacs-27, let me know.
> >
> > Thanks for the patch! I noticed that it made it to master as commit
> > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you
> > still planning to backport it?
>
> Yes, it definitely needs to be backported. Eli, what do I need to do to get this
> backported to Emacs 27? This was a bad breaking change to 27 that I fixed after
> the release branch was cut. Let me know if I need to do a separate commit or take
> other action to get this done...
>
Typically you'd cherry-pick the commit onto the release branch. But
since Emacs 27 is about to be released (tomorrow), it might be too
late now.
next prev parent reply other threads:[~2020-08-09 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 22:39 bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Philipp
2020-03-07 7:43 ` Eli Zaretskii
2020-03-13 9:53 ` Eli Zaretskii
2020-03-23 1:20 ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-03-23 14:24 ` Eli Zaretskii
2020-07-28 20:06 ` Philipp Stephani
2020-08-09 2:13 ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-09 9:14 ` Philipp Stephani [this message]
2020-08-09 14:02 ` Eli Zaretskii
2020-10-01 18:36 ` Lars Ingebrigtsen
2020-10-04 18:49 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkQJ2vmeA=4PHj_UxquKNRZzLQ3L=JAbHrMOvehu83r+hA@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=39960@debbugs.gnu.org \
--cc=mmauger@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).