From: Eli Zaretskii <eliz@gnu.org>
To: Philipp <p.stephani2@gmail.com>, Michael Mauger <michael@mauger.com>
Cc: 39960@debbugs.gnu.org
Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27
Date: Sat, 07 Mar 2020 09:43:39 +0200 [thread overview]
Message-ID: <837dzwboes.fsf@gnu.org> (raw)
In-Reply-To: <m27dzxw1kb.fsf@gmail.com> (message from Philipp on Fri, 06 Mar 2020 23:39:16 +0100)
> From: Philipp <p.stephani2@gmail.com>
> Date: Fri, 06 Mar 2020 23:39:16 +0100
>
>
> In Emacs 26, sql-add-product has the signature
>
> (sql-add-product PRODUCT DISPLAY &rest PLIST)
>
> However, in the Emacs 27 pretest the signature is now
>
> (sql-add-product PRODUCT DISPLAY &optional PLIST)
>
> Note the change from &rest to &optional. This is a breaking change that
> breaks all users of sql-add-product. I've found quite a few uses of the
> old signature in the wild,
> e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59
> or
> https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68
> or
> https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71.
> This change was introduced in commit
> c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should
> introduce such a breaking change to a widely-used public function; at
> the very least, Emacs 27 should accept both signatures.
Thanks for reporting this.
Michael, could you please look into this ASAP? TIA.
Btw, this change of a public API is not in NEWS, AFAICT; if we decide
eventually on keeping the change, we should announce it in NEWS.
next prev parent reply other threads:[~2020-03-07 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 22:39 bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Philipp
2020-03-07 7:43 ` Eli Zaretskii [this message]
2020-03-13 9:53 ` Eli Zaretskii
2020-03-23 1:20 ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-03-23 14:24 ` Eli Zaretskii
2020-07-28 20:06 ` Philipp Stephani
2020-08-09 2:13 ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-09 9:14 ` Philipp Stephani
2020-08-09 14:02 ` Eli Zaretskii
2020-10-01 18:36 ` Lars Ingebrigtsen
2020-10-04 18:49 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dzwboes.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39960@debbugs.gnu.org \
--cc=michael@mauger.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).