From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Sun, 9 Aug 2020 11:14:24 +0200 Message-ID: References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org> To: Michael Mauger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 11:15:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4hQ7-00081i-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 11:15:11 +0200 Original-Received: from localhost ([::1]:48524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4hQ5-00055f-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 05:15:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4hPy-00055V-PI for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 05:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4hPy-0006fb-D2 for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 05:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4hPy-0007ez-7Z for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs Original-Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.159696448529403 (code B ref 39960); Sun, 09 Aug 2020 09:15:02 +0000 Original-Received: (at 39960) by debbugs.gnu.org; 9 Aug 2020 09:14:45 +0000 Original-Received: from localhost ([127.0.0.1]:59942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hPg-0007eA-OA for submit@debbugs.gnu.org; Sun, 09 Aug 2020 05:14:45 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:42964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hPd-0007du-8g for 39960@debbugs.gnu.org; Sun, 09 Aug 2020 05:14:43 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id j7so6180731oij.9 for <39960@debbugs.gnu.org>; Sun, 09 Aug 2020 02:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pzq4C9cRtX5hZ6V3TqL2hoqJe/DAGr/5wLV71Pm+a4E=; b=vCWtly3IwaTCmCjyFwls8R6/vj2zVkrRy+LRb+fXyzHpLoG4/p9lizn2KsipYeSVnv SwYMVdsPwtBPIOwYoQPTFF0QIR1DARsaBts1qwK/+71mKg48G2ANeLPaBHhP5M/Pzr6y v1piG01cQinjf0qjgSAGs+7R0g5CCAEdHPWh//cZCw6oegV360VgAgNvuu7IH17mtezt pphxHeFCA5R3Iy4FiEfX+jYsnCNqTb2WW3hTbhKuKcLU8HD5/ypz7Y3S527o08k7q2NA O+hTYM4WYoNmUWrfEovFF/WCGttV6azu5wpVl3R/0lsLhRBfpQjVeeUSQYTqjow2EjR8 JnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pzq4C9cRtX5hZ6V3TqL2hoqJe/DAGr/5wLV71Pm+a4E=; b=qx/ogVIzLodYfTifO0Wic/4IxXfHJ35GricrXnoEt0fXXXumntKXJZpEEzaAHCTVGT 2oJFOn5mSelwCIJR16jJppAbdvkK8qM3dcsBKCJT0tc2dm2Ia9saHCFSLE3hG/sUEGG7 wJs6Fw3lt2EWhng91r+lUhVTYWcFaWJ23w9BOp3C0ggCM3T+x9bmbubd7lTexemJGQRm KzjyrbhE5fHa9oKyesdpex0e6UxDbAhgwq6ULDiHw2LYhH4lsKn8gyctpFIaVeG1uVQQ seRLFt3es10Eq0pG/0XJi0CLkjZCVPNcnSeHXgee2kwSzdEp2m3AD74FwLN4/Lf3fTik 5iMw== X-Gm-Message-State: AOAM533myhCSNeaca7PkHlleDzPBYxud9RWlGkD8Nw/uYc7d32exVdi0 l/TDiePuf4DODGPcaf4S1pR9Wsdvh7ybFgH5M8A= X-Google-Smtp-Source: ABdhPJyQ3gfyYZ8zzdjWtlzwsheD4qok2gyetsG6WyDrmyMi0/tGISwfO4PG/r+mTM87kCEvaFucbNDnWbV+QPUCdEw= X-Received: by 2002:aca:2101:: with SMTP id 1mr18244121oiz.170.1596964475547; Sun, 09 Aug 2020 02:14:35 -0700 (PDT) In-Reply-To: <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184386 Archived-At: Am So., 9. Aug. 2020 um 04:14 Uhr schrieb Michael Mauger : > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani wrote: > > > Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger > > mmauger@protonmail.com: > > > > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Origi= nal Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz@gnu.org wrote: > > > > > > > Ping! > > > > > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > > > From: Eli Zaretskii eliz@gnu.org > > > > > Cc: 39960@debbugs.gnu.org > > > > > > > > > > > From: Philipp p.stephani2@gmail.com > > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > > In Emacs 26, sql-add-product has the signature > > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > > > However, in the Emacs 27 pretest the signature is now > > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > > > Note the change from &rest to &optional. This is a breaking cha= nge that > > > > > > breaks all users of sql-add-product. I've found quite a few use= s of the > > > > > > old signature in the wild, > > > > > > > > > > Thanks for reporting this. > > > > > Michael, could you please look into this ASAP? TIA. > > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we de= cide > > > > > eventually on keeping the change, we should announce it in NEWS. > > > > > > Sorry for the delay. The massive switch to WFH and illness concerns a= t home > > > interfered. All are fine, and I actually do get work done occasionall= y. > > > > No worries, and good to hear that! > > > > > I've got the following patch to make. I assume it needs to be made to= the > > > emacs-27 branch and corresponding patches made to master as well. If = I > > > should only commit to master (same change is needed there) for cherry= -picking > > > for emacs-27, let me know. > > > > Thanks for the patch! I noticed that it made it to master as commit > > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you > > still planning to backport it? > > Yes, it definitely needs to be backported. Eli, what do I need to do to g= et this > backported to Emacs 27? This was a bad breaking change to 27 that I fixed= after > the release branch was cut. Let me know if I need to do a separate commit= or take > other action to get this done... > Typically you'd cherry-pick the commit onto the release branch. But since Emacs 27 is about to be released (tomorrow), it might be too late now.