From: "Mattias Engdegård" <mattiase@acm.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Shigeru Fukaya <shigeru.fukaya@gmail.com>,
44861-done@debbugs.gnu.org,
Stefan Kangas <stefankangas@gmail.com>,
Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string'
Date: Thu, 26 Nov 2020 14:39:01 +0100 [thread overview]
Message-ID: <C136B0DC-1CC5-499E-8BBD-14EAF9E2A4EB@acm.org> (raw)
In-Reply-To: <871rggs1mk.fsf@gnus.org>
26 nov. 2020 kl. 14.12 skrev Lars Ingebrigtsen <larsi@gnus.org>:
> I'm all for speeding up replace-regexp-in-string (which is used all over
> the place), so your change looks reasonable to me.
Thank you! Pushed to master.
> But I wonder -- would it make sense to move the entire
> replace-regexp-in-string function to C?
Probably, but that would be a pure performance improvement. Most of the time is currently consumed in primitives (string-match, replace-match, substring, concat) so don't expect huge savings unless a substantially different approach is taken.
(Dmitry Gutov asked for a C implementation in bug#20273 for improving the speed of json encoding; is that still relevant?)
A bigger saving yet would be to use the much faster string-replace wherever possible. A little sweeping refactoring project perhaps? It would also improve readability -- no regexp quoting, fewer mysterious arguments like LITERAL and FIXEDCASE to worry about, etc.
next prev parent reply other threads:[~2020-11-26 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 4:02 bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Shigeru Fukaya
2020-11-25 10:58 ` Mattias Engdegård
2020-11-25 14:58 ` Mattias Engdegård
2020-11-25 21:39 ` Stefan Kangas
2020-11-26 12:57 ` Mattias Engdegård
2020-11-26 13:12 ` Lars Ingebrigtsen
2020-11-26 13:39 ` Mattias Engdegård [this message]
2020-11-26 14:03 ` Lars Ingebrigtsen
2020-11-26 14:54 ` Mattias Engdegård
2020-11-29 13:28 ` Basil L. Contovounesios
2020-11-26 13:43 ` Stefan Kangas
2020-11-26 14:03 ` Lars Ingebrigtsen
2020-11-26 14:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C136B0DC-1CC5-499E-8BBD-14EAF9E2A4EB@acm.org \
--to=mattiase@acm.org \
--cc=44861-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=shigeru.fukaya@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).