From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Date: Thu, 26 Nov 2020 14:39:01 +0100 Message-ID: References: <6F768DED-2E1B-4D06-A776-FFA162AC32AD@acm.org> <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> <83EC926B-DE9E-48BC-8FD2-C7CB3617AD50@acm.org> <871rggs1mk.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Shigeru Fukaya , 44861-done@debbugs.gnu.org, Stefan Kangas , Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 14:40:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiHVQ-0000x4-3L for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 14:40:16 +0100 Original-Received: from localhost ([::1]:35412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiHVP-0008Rr-3T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 08:40:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiHVD-0008Na-BM for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiHVC-0007JZ-I1 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiHVC-0002vL-FN for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:40:02 -0500 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Mail-Followup-To: 44861@debbugs.gnu.org, mattiase@acm.org, shigeru.fukaya@gmail.com Original-Received: via spool by 44861-done@debbugs.gnu.org id=D44861.160639794911142 (code D ref 44861); Thu, 26 Nov 2020 13:40:02 +0000 Original-Received: (at 44861-done) by debbugs.gnu.org; 26 Nov 2020 13:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:40212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiHUL-0002td-68 for submit@debbugs.gnu.org; Thu, 26 Nov 2020 08:39:09 -0500 Original-Received: from mail18c50.megamailservers.eu ([91.136.10.28]:35314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiHUI-0002tU-AF for 44861-done@debbugs.gnu.org; Thu, 26 Nov 2020 08:39:07 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1606397944; bh=qRtUDaLl5H17p0RDB4FfvX9bEjX+S3TmznMxIhHbgxE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=KET9zSevJRb7BWv7KCOGosvyl0QLQ74BOTruefHc0UwmF1MsYU9W1WtXYkS8HZVRJ UWHBMNGCwd+hwVDmmN4rDhjgRvoSobqN349KkR/QLXkSiuag+EGXW9yND+Tx8X31G3 tlUcY20i5huTZWpddD2COSJbX0WwzBSKFw2G49uM= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0AQDd2TT030149; Thu, 26 Nov 2020 13:39:03 +0000 In-Reply-To: <871rggs1mk.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F1C.5FBFAFF8.006F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c8jVvi1l c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=7AurVBKHxq3X-xEwr_MA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194317 Archived-At: 26 nov. 2020 kl. 14.12 skrev Lars Ingebrigtsen : > I'm all for speeding up replace-regexp-in-string (which is used all = over > the place), so your change looks reasonable to me. Thank you! Pushed to master. > But I wonder -- would it make sense to move the entire > replace-regexp-in-string function to C? Probably, but that would be a pure performance improvement. Most of the = time is currently consumed in primitives (string-match, replace-match, = substring, concat) so don't expect huge savings unless a substantially = different approach is taken. (Dmitry Gutov asked for a C implementation in bug#20273 for improving = the speed of json encoding; is that still relevant?) A bigger saving yet would be to use the much faster string-replace = wherever possible. A little sweeping refactoring project perhaps? It = would also improve readability -- no regexp quoting, fewer mysterious = arguments like LITERAL and FIXEDCASE to worry about, etc.