bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS)

[Illia Ostapyshyn <ilya.ostapyshyn@gmail.com>]

Executing like this doesn't work for me:

    emacs -Q --execute "(push '(fullscreen . fullboth) default-frame-alist)"

I've tried recompiling emacs with you configure flags, same result. Could it be the OS version? I doubt it, I recall having this issue long time ago, but I bore with it instead of reporting.

The patch didn't fix the issue, but there are two more instances of waitFullScreenTransition in nsterm.m. I narrowed it down to this one:

diff --git a/src/nsterm.m b/src/nsterm.m
index bb20886ab1..bf18ae48fa 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8061,8 +8061,6 @@ - (void)toggleFullScreen: (id)sender
         {
 #endif
           [[self window] toggleFullScreen:sender];
-          // wait for fullscreen animation complete (bug#28496)
-          [self waitFullScreenTransition];
 #if MAC_OS_X_VERSION_MIN_REQUIRED < 1070
         }
 #endif

> I can't reproduce this.  Modifying the early-init.el file or executing
> Emacs like this works fine for me:
> 
> emacs -Q --execute "(push '(fullscreen . fullboth) default-frame-alist)"
> 
> But my OS and Emacs configuration is different:
> System Description:  macOS 11.2.3
> Configured using: 'configure --with-ns --with-rsvg'
> 
> Illia, please check if this small fix will help:
> 
> diff --git a/src/nsterm.m b/src/nsterm.m
> index bb20886ab1..ef517098bf 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -1640,8 +1640,6 @@ -(void)remove
>          fullscreen also.  So skip handleFS as this will print an error.  */
>       if ([view fsIsNative] && [view isFullscreen])
>         {
> -          // maybe it is not necessary to wait
> -          [view waitFullScreenTransition];
>           return;
>         }