From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Illia Ostapyshyn Newsgroups: gmane.emacs.bugs Subject: bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS) Date: Fri, 14 May 2021 11:13:13 +0200 Message-ID: References: <5E1B46C6-1359-4CCF-B4EF-5527FB915F93@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3933"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48406@debbugs.gnu.org, Alan Third To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 14 11:14:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhTtn-0000qG-2J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 11:14:23 +0200 Original-Received: from localhost ([::1]:47058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhTtm-0003l8-0q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 05:14:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhTtT-0003kt-Sa for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 05:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhTtS-0005b1-7v for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 05:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhTtS-0003sb-3t for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Illia Ostapyshyn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 May 2021 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48406 X-GNU-PR-Package: emacs Original-Received: via spool by 48406-submit@debbugs.gnu.org id=B48406.162098360214857 (code B ref 48406); Fri, 14 May 2021 09:14:02 +0000 Original-Received: (at 48406) by debbugs.gnu.org; 14 May 2021 09:13:22 +0000 Original-Received: from localhost ([127.0.0.1]:45001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhTso-0003rZ-JC for submit@debbugs.gnu.org; Fri, 14 May 2021 05:13:22 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:35527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhTsm-0003rM-JG for 48406@debbugs.gnu.org; Fri, 14 May 2021 05:13:21 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id di13so33949618edb.2 for <48406@debbugs.gnu.org>; Fri, 14 May 2021 02:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=a/JfsN9e6H9ESem0RfPUhahm/itR9QUfTopHYcnf3j4=; b=iEdduLSnqPY+P6d7HRXskLJOnIu1ra8xZZGhnkv3VDSxOZCF1nlLMUQ4+Nn0zenaS/ v13fwSfr2gt/WTxbHqRG6GyDRFi+oU6tVo7C5MZsLFbCjlXiGBlDg7QwijzC1ueONQwe 0kzJxiYOm+0V91rXuBsW668T7iSQHzrwokHERJjKufcxyBsV7OA0kCcXGVKoDwkRFwdq rrALJfIeV7Ec1EZQPo3cwzUgJJWSQZaCd8tBrNM+qjtjBujSphM+6USNlnfyZaLMHrs7 R+DXikWY4iJnk0nO26JafITKqBnQhVo+JOkaGQBoW9GC3LpHguVGjOZkqApfHPBQPXak pyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=a/JfsN9e6H9ESem0RfPUhahm/itR9QUfTopHYcnf3j4=; b=LvVHOwcswhIkVIWwllVBgmIccJrhWik79RxegzkueaBehRAqOiFpxBHBtnLedd0C1D Tmfjl18BncxPQOZAqWb/HLA0kmou/m5zZotDQYZXSRjWg8AjuUKoNVntjRrs0oWw7Xud Dojkp1a8XaqqDocJdNALm9FKltEhKliOnhVg2ltyBUn2cmrGBq5Li58mkugmAOQmjALE FkOyMQG0LfieFvN4GShK2fDk9RNxbQJjK1TkUaq4AlDY+cUSt6yBy6kqTXGzhF8TCY88 fAauOtX/soch6JURa8N1Dg4ebwYJJGwdhcESv9nIFTjELpwGD7XRio2vU64wDysjc9IO PXRQ== X-Gm-Message-State: AOAM530lx+kozhxMIplu63ro+5hZw8916yIaButojN4ofDZ2jlc+9BM9 Nxb1RPR0A1s5SdRhb0W9XbY= X-Google-Smtp-Source: ABdhPJxHWbf6TE70Gke9uDITfhEb0/2nNT1D4aqujjJj/8pb+dcHCTqKEAF3vlOuNXtSafgHB3lnhQ== X-Received: by 2002:a50:9f6b:: with SMTP id b98mr3625256edf.318.1620983594736; Fri, 14 May 2021 02:13:14 -0700 (PDT) Original-Received: from smtpclient.apple (ip185112.wh.uni-hannover.de. [130.75.185.112]) by smtp.gmail.com with ESMTPSA id i19sm3182646ejd.114.2021.05.14.02.13.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 May 2021 02:13:14 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.80.0.2.43) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206501 Archived-At: Executing like this doesn't work for me: emacs -Q --execute "(push '(fullscreen . fullboth) = default-frame-alist)" I've tried recompiling emacs with you configure flags, same result. = Could it be the OS version? I doubt it, I recall having this issue long = time ago, but I bore with it instead of reporting. The patch didn't fix the issue, but there are two more instances of = waitFullScreenTransition in nsterm.m. I narrowed it down to this one: diff --git a/src/nsterm.m b/src/nsterm.m index bb20886ab1..bf18ae48fa 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8061,8 +8061,6 @@ - (void)toggleFullScreen: (id)sender { #endif [[self window] toggleFullScreen:sender]; - // wait for fullscreen animation complete (bug#28496) - [self waitFullScreenTransition]; #if MAC_OS_X_VERSION_MIN_REQUIRED < 1070 } #endif > I can't reproduce this. Modifying the early-init.el file or executing > Emacs like this works fine for me: >=20 > emacs -Q --execute "(push '(fullscreen . fullboth) = default-frame-alist)" >=20 > But my OS and Emacs configuration is different: > System Description: macOS 11.2.3 > Configured using: 'configure --with-ns --with-rsvg' >=20 > Illia, please check if this small fix will help: >=20 > diff --git a/src/nsterm.m b/src/nsterm.m > index bb20886ab1..ef517098bf 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -1640,8 +1640,6 @@ -(void)remove > fullscreen also. So skip handleFS as this will print an = error. */ > if ([view fsIsNative] && [view isFullscreen]) > { > - // maybe it is not necessary to wait > - [view waitFullScreenTransition]; > return; > }