From: Alan Third <alan@idiocy.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: Illia Ostapyshyn <ilya.ostapyshyn@gmail.com>, 48406@debbugs.gnu.org
Subject: bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS)
Date: Fri, 14 May 2021 21:34:42 +0100 [thread overview]
Message-ID: <YJ7e4lCDnnpcI4kg@breton.holly.idiocy.org> (raw)
In-Reply-To: <m235up3yc7.fsf@gmail.com>
On Fri, May 14, 2021 at 10:32:56PM +0300, Andrii Kolomoiets wrote:
> Illia Ostapyshyn <ilya.ostapyshyn@gmail.com> writes:
>
> > Executing like this doesn't work for me:
> >
> > emacs -Q --execute "(push '(fullscreen . fullboth) default-frame-alist)"
> >
> > I've tried recompiling emacs with you configure flags, same
> > result. Could it be the OS version? I doubt it, I recall having this
> > issue long time ago, but I bore with it instead of reporting.
>
> Well, I'm on macOS 11.3.1 now, recompiled Emacs with `make bootstrap`
> still works fine.
Now I've dug out my Mac I can confirm I see this hang as well.
The problem is that we never reach the NS run loop and therefore
windowDidEnterFullScreen is never called.
It appears ns_select returns in this code:
if (hold_event_q.nr > 0)
{
/* We already have events pending. */
raise (SIGIO);
errno = EINTR;
return -1;
}
hmmmm.......
This fixes it for me, but whether it's a good idea or not I don't know:
modified src/nsterm.m
@@ -7876,6 +7876,7 @@ - (void)windowDidEnterFullScreen:(NSNotification *)notification
NSTRACE ("[EmacsView windowDidEnterFullScreen:]");
[self windowDidEnterFullScreen];
in_fullscreen_transition = NO;
+ ns_send_appdefined (-1);
}
- (void)windowDidEnterFullScreen /* provided for direct calls */
@@ -7935,6 +7936,7 @@ - (void)windowDidExitFullScreen:(NSNotification *)notification
NSTRACE ("[EmacsView windowDidExitFullScreen:]");
[self windowDidExitFullScreen];
in_fullscreen_transition = NO;
+ ns_send_appdefined (-1);
}
- (void)windowDidExitFullScreen /* provided for direct calls */
@@ -7974,7 +7976,7 @@ - (void)waitFullScreenTransition
while ([self inFullScreenTransition])
{
NSTRACE ("wait for fullscreen");
- wait_reading_process_output (0, 300000000, 0, 1, Qnil, NULL, 0);
+ [NSApp run];
}
#endif
}
--
Alan Third
next prev parent reply other threads:[~2021-05-14 20:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 20:39 bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS) Illia Ostapyshyn
2021-05-13 21:15 ` Alan Third
2021-05-14 6:07 ` Andrii Kolomoiets
2021-05-14 9:13 ` Illia Ostapyshyn
2021-05-14 19:32 ` Andrii Kolomoiets
2021-05-14 20:34 ` Alan Third [this message]
2021-05-15 19:44 ` Andrii Kolomoiets
2021-05-15 22:47 ` Alan Third
2021-05-16 20:09 ` Andrii Kolomoiets
2021-05-26 20:26 ` Alan Third
2021-05-26 20:28 ` Alan Third
2021-06-05 13:45 ` Alan Third
2021-06-05 16:21 ` Illia Ostapyshyn
2021-06-05 16:33 ` Alan Third
2021-06-09 21:01 ` Alan Third
2021-05-14 22:53 ` Filipp Gunbin
2021-05-15 8:34 ` Illia Ostapyshyn
2021-05-14 6:22 ` Eli Zaretskii
2021-05-14 9:22 ` Illia Ostapyshyn
2021-05-14 10:55 ` Eli Zaretskii
2021-05-14 11:09 ` Illia Ostapyshyn
2021-05-14 11:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ7e4lCDnnpcI4kg@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=48406@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=ilya.ostapyshyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).