From: "Drew Adams" <drew.adams@oracle.com>
To: "'Karl Fogel'" <kfogel@red-bean.com>
Cc: 12504@debbugs.gnu.org
Subject: bug#12504: `bookmark-rename' and `bookmark-maybe-historicize-string'
Date: Mon, 1 Oct 2012 14:34:04 -0700 [thread overview]
Message-ID: <B609652D36144C569635CBD69C44C4A6@us.oracle.com> (raw)
In-Reply-To: <87bogldgs9.fsf@kwarm.red-bean.com>
> >I agree about the usefulness, but I think it should be done only when
> >`bookmark-rename' is invoked interactively.
>
> When I say "interactively", I'm including both minibuffer command
> and menu command -- anything the user did interactively, that is.
Yes, that's what I meant here, too.
But that is not what the code does, I believe. It adds the name to the history
even when bookmark-rename is invoked non-interactively.
> >... That's a bad workaround if the goal is to add to the
> > history when the user uses the menu: non-interactively is not
> > the same thing as interactively-using-a-menu.
>
> Sure, completely agree. We're on the same page,
> conceptually; the code just needs fixing, that's all :-).
> I'll try to do it, but am busy for a while again.
Thanks. But again, this really is not specific to bookmark commands. A more
general solution should be found, IMO.
For bookmark.el, I would be happy if we did not try to add menu-invoked commands
to the histry, and we just waited for a general solution.
But I would also be happy if you implement a bookmark.el solution that does what
we mentioned above: add to the history only when invoked by the user,
interactively (menu or keys).
next prev parent reply other threads:[~2012-10-01 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 17:04 bug#12504: 24.2.50; `bookmark-rename' and `bookmark-maybe-historicize-string' Drew Adams
2012-10-01 3:57 ` bug#12504: " Karl Fogel
2012-10-01 4:29 ` Drew Adams
2012-10-01 21:27 ` Karl Fogel
2012-10-01 21:34 ` Drew Adams [this message]
2012-10-01 22:31 ` Karl Fogel
2021-12-04 4:58 ` bug#12504: 24.2.50; " Lars Ingebrigtsen
2021-12-04 20:08 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B609652D36144C569635CBD69C44C4A6@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=12504@debbugs.gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).