From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12504: `bookmark-rename' and `bookmark-maybe-historicize-string' Date: Mon, 1 Oct 2012 14:34:04 -0700 Message-ID: References: <736CB5A93DF64F6BB3FDF32A163C35B3@us.oracle.com><87lifqhmj2.fsf@floss.red-bean.com><8B5272B140EB45FB822FEA3D45F3FB46@us.oracle.com> <87bogldgs9.fsf@kwarm.red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349127288 12237 80.91.229.3 (1 Oct 2012 21:34:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 21:34:48 +0000 (UTC) Cc: 12504@debbugs.gnu.org To: "'Karl Fogel'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 01 23:34:52 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIndT-0000V0-Oe for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 23:34:43 +0200 Original-Received: from localhost ([::1]:41374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIndO-0002q7-5p for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 17:34:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIndL-0002pL-65 for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 17:34:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIndK-0005PZ-5u for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 17:34:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIndK-0005PV-1N for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 17:34:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIndm-0005HE-6b for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 17:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Oct 2012 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12504-submit@debbugs.gnu.org id=B12504.134912729320269 (code B ref 12504); Mon, 01 Oct 2012 21:35:02 +0000 Original-Received: (at 12504) by debbugs.gnu.org; 1 Oct 2012 21:34:53 +0000 Original-Received: from localhost ([127.0.0.1]:36796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIndc-0005Gs-Ng for submit@debbugs.gnu.org; Mon, 01 Oct 2012 17:34:53 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:32763) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TInda-0005Gk-8b for 12504@debbugs.gnu.org; Mon, 01 Oct 2012 17:34:51 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q91LYJuO029464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Oct 2012 21:34:20 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q91LYJ7i009127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2012 21:34:19 GMT Original-Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q91LYJj8008276; Mon, 1 Oct 2012 16:34:19 -0500 Original-Received: from dradamslap1 (/10.159.219.190) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 01 Oct 2012 14:34:19 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87bogldgs9.fsf@kwarm.red-bean.com> Thread-Index: Ac2gG5W38dwylQwvRK6ABJRbIdfiuQAAEVyg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65096 Archived-At: > >I agree about the usefulness, but I think it should be done only when > >`bookmark-rename' is invoked interactively. > > When I say "interactively", I'm including both minibuffer command > and menu command -- anything the user did interactively, that is. Yes, that's what I meant here, too. But that is not what the code does, I believe. It adds the name to the history even when bookmark-rename is invoked non-interactively. > >... That's a bad workaround if the goal is to add to the > > history when the user uses the menu: non-interactively is not > > the same thing as interactively-using-a-menu. > > Sure, completely agree. We're on the same page, > conceptually; the code just needs fixing, that's all :-). > I'll try to do it, but am busy for a while again. Thanks. But again, this really is not specific to bookmark commands. A more general solution should be found, IMO. For bookmark.el, I would be happy if we did not try to add menu-invoked commands to the histry, and we just waited for a general solution. But I would also be happy if you implement a bookmark.el solution that does what we mentioned above: add to the history only when invoked by the user, interactively (menu or keys).