From: Karl Fogel <kfogel@red-bean.com>
To: 12504@debbugs.gnu.org
Subject: bug#12504: `bookmark-rename' and `bookmark-maybe-historicize-string'
Date: Sun, 30 Sep 2012 22:57:37 -0500 [thread overview]
Message-ID: <87lifqhmj2.fsf@floss.red-bean.com> (raw)
In-Reply-To: <736CB5A93DF64F6BB3FDF32A163C35B3@us.oracle.com>
I agree there is a bug, or maybe a buglet, here, for the reasons you
describe, but I'm not sure how to solve it.
Does invoking functions through a menu result in an environment where
`called-interactively-p' returns non-nil? In that case, the premise
behind `bookmark-maybe-historicize-string' is all wrong anyway, and the
macro should be rewritten to:
`(when (called-interactively-p 'interactive)
(setq bookmark-history (cons ,string bookmark-history))))
The issue is larger than just `bookmark-rename', obviously.
By the way, your guess is right: it's useful (I think) to have the old
name in the history for `bookmark-rename', because someone may want to
use it or a variant of it in another bookmark soon. History is cheap
that way: it's better to have a little junk than to *not* have the thing
the user needs when they need it.
Let's tackle the larger issue with `bookmark-maybe-historicize-string',
and then figure out whether `bookmark-rename' is doing the right thing.
-Karl
next prev parent reply other threads:[~2012-10-01 3:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 17:04 bug#12504: 24.2.50; `bookmark-rename' and `bookmark-maybe-historicize-string' Drew Adams
2012-10-01 3:57 ` Karl Fogel [this message]
2012-10-01 4:29 ` bug#12504: " Drew Adams
2012-10-01 21:27 ` Karl Fogel
2012-10-01 21:34 ` Drew Adams
2012-10-01 22:31 ` Karl Fogel
2021-12-04 4:58 ` bug#12504: 24.2.50; " Lars Ingebrigtsen
2021-12-04 20:08 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lifqhmj2.fsf@floss.red-bean.com \
--to=kfogel@red-bean.com \
--cc=12504@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).