From: "Drew Adams" <drew.adams@oracle.com>
To: 7118@debbugs.gnu.org
Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Mon, 27 Sep 2010 11:47:39 -0700 [thread overview]
Message-ID: <B53179EFF1B54D4EA98E63D1B3DD2602@us.oracle.com> (raw)
We should use `make-variable-buffer-local' with vars such as
`dired-subdir-alist' and `dired-directory', instead of just calling
`make-local-variable'. Why? Because these vars MUST be buffer local,
and we might as well make the code clearer by pointing that out. That
is precisely the use case for `make-variable-buffer-local': a var that
is necessarily buffer-local.
Also, the doc strings are otherwise incomplete/vague: for
`dired-subdir-alist', for example, it speaks of "the buffer". The var's
value is local to each particular Dired buffer, and this needs to be
made more clear. If we use `make-variable-buffer-local' that will add
the necessary info to `C-h v' so that the doc strings begin to make
sense. (Still, we should mention in the doc string of
`dired-subdir-alist' that the subdirs are subdirs of `dired-directory'.)
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-09-20 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
next reply other threads:[~2010-09-27 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 18:47 Drew Adams [this message]
2010-09-27 21:05 ` bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Stefan Monnier
2011-07-14 14:21 ` Lars Magne Ingebrigtsen
2011-07-14 14:45 ` Juanma Barranquero
2011-07-14 14:49 ` Lars Magne Ingebrigtsen
2011-07-17 2:24 ` Stefan Monnier
2011-08-02 21:11 ` Drew Adams
2010-09-27 23:35 ` Juanma Barranquero
2022-02-07 0:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B53179EFF1B54D4EA98E63D1B3DD2602@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=7118@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).