unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, 7118@debbugs.gnu.org
Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Sat, 16 Jul 2011 22:24:37 -0400	[thread overview]
Message-ID: <jwvk4bhzlxe.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3ipr4zzm8.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 14 Jul 2011 16:49:19 +0200")

>> But IMHO, neither changing `revert-buffer-function' nor
>> `dired-subdir-alist' and `dired-directory' is really a bug fix.  Yes,
>> as they are now is error prone, but the uses in the sources are
>> already correct. That should be a wishlist item for 24.2.

Indeed.  Also always be extra careful that none of the `setq'
(resulting from removal of make-local-variable) can run before the
make-variable-buffer-local.  This is usually trivially the case, but
problems can appear if the setq is within an autoloaded expression or
when several files are involved.


        Stefan





  reply	other threads:[~2011-07-17  2:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 18:47 bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Drew Adams
2010-09-27 21:05 ` Stefan Monnier
2011-07-14 14:21   ` Lars Magne Ingebrigtsen
2011-07-14 14:45     ` Juanma Barranquero
2011-07-14 14:49       ` Lars Magne Ingebrigtsen
2011-07-17  2:24         ` Stefan Monnier [this message]
2011-08-02 21:11           ` Drew Adams
2010-09-27 23:35 ` Juanma Barranquero
2022-02-07  0:31 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk4bhzlxe.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=7118@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).