From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Date: Mon, 27 Sep 2010 11:47:39 -0700 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1285615133 19794 80.91.229.12 (27 Sep 2010 19:18:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Sep 2010 19:18:53 +0000 (UTC) To: 7118@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 27 21:18:50 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0JDt-0007dm-4r for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Sep 2010 21:18:49 +0200 Original-Received: from localhost ([127.0.0.1]:52585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0J6k-0004B0-UN for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Sep 2010 15:11:26 -0400 Original-Received: from [140.186.70.92] (port=56633 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0J6f-0004Av-7K for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 15:11:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0J6e-0001vQ-0y for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 15:11:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56300) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0J6d-0001vM-TE for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 15:11:19 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0IiB-0000cY-9M; Mon, 27 Sep 2010 14:46:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Sep 2010 18:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.12856131022346 (code B ref -1); Mon, 27 Sep 2010 18:46:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Sep 2010 18:45:02 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0IhB-0000bn-NB for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:45:01 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ih9-0000bX-Oc for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:45:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0Ijr-0007Eg-EQ for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:47:48 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:50262) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ijr-0007Ec-8t for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:47:47 -0400 Original-Received: from [140.186.70.92] (port=36887 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0Ijq-0004ai-2d for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0Ijo-0007Dx-PN for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:45 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:33110) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ijo-0007Dj-Id for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:44 -0400 Original-Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o8RIlf8v030295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Sep 2010 18:47:43 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o8RIgrBb000794 for ; Mon, 27 Sep 2010 18:47:41 GMT Original-Received: from abhmt004.oracle.com by acsmt354.oracle.com with ESMTP id 640730431285613258; Mon, 27 Sep 2010 11:47:38 -0700 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 27 Sep 2010 11:47:38 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: ActedHWdZ8VRbaNdT7yU3uwVdwQ6kg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 27 Sep 2010 14:46:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40497 Archived-At: We should use `make-variable-buffer-local' with vars such as `dired-subdir-alist' and `dired-directory', instead of just calling `make-local-variable'. Why? Because these vars MUST be buffer local, and we might as well make the code clearer by pointing that out. That is precisely the use case for `make-variable-buffer-local': a var that is necessarily buffer-local. Also, the doc strings are otherwise incomplete/vague: for `dired-subdir-alist', for example, it speaks of "the buffer". The var's value is local to each particular Dired buffer, and this needs to be made more clear. If we use `make-variable-buffer-local' that will add the necessary info to `C-h v' so that the doc strings begin to make sense. (Still, we should mention in the doc string of `dired-subdir-alist' that the subdirs are subdirs of `dired-directory'.) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-09-20 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'