bug#46914: [PATCH] Call the set_buffer_overlays setters

bug#46914: [PATCH] Call the set_buffer_overlays setters

[Matt Armstrong]

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]

`kill-buffer' was an oddball function.  With this patch it is less so.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Call-the-set_buffer_overlays_-setters.patch --]
[-- Type: text/x-patch, Size: 1089 bytes --]

From dfe95ffc6a091d44a22854344f43215074a8fe05 Mon Sep 17 00:00:00 2001
From: Matt Armstrong <matt@mdeb>
Date: Wed, 3 Mar 2021 16:02:52 -0800
Subject: [PATCH] Call the set_buffer_overlays_ setters

Apart from the setters themselves, this is the only place the fields
were set directly.

* src/buffer.c (Fkill_buffer): Call set_buffer_overlays_before and
set_buffer_overlays_after instead of setting the fields directly.
---
 src/buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/buffer.c b/src/buffer.c
index 5bd9b37702..03c10cc7ae 100644
--- a/src/buffer.c
+++ b/src/buffer.c
@@ -1942,8 +1942,8 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0, 1, "bKill buffer: ",
     }
   /* Since we've unlinked the markers, the overlays can't be here any more
      either.  */
-  b->overlays_before = NULL;
-  b->overlays_after = NULL;
+  set_buffer_overlays_before (b, NULL);
+  set_buffer_overlays_after (b, NULL);
 
   /* Reset the local variables, so that this buffer's local values
      won't be protected from GC.  They would be protected
-- 
2.30.0

bug#46914: [PATCH] Call the set_buffer_overlays setters

[Lars Ingebrigtsen]

Matt Armstrong <matt@rfc20.org> writes:

> Apart from the setters themselves, this is the only place the fields
> were set directly.
>
> * src/buffer.c (Fkill_buffer): Call set_buffer_overlays_before and
> set_buffer_overlays_after instead of setting the fields directly.

Makes sense; pushed to Emacs 28 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no