From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#46914: [PATCH] Call the set_buffer_overlays setters Date: Wed, 03 Mar 2021 18:24:46 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30867"; mail-complaints-to="usenet@ciao.gmane.io" To: 46914@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 03:25:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHdft-0007t4-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 03:25:13 +0100 Original-Received: from localhost ([::1]:59106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHdfs-0002oZ-LE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 21:25:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHdfm-0002oO-ND for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:25:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHdfi-0000Uz-Dz for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:25:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHdfi-0000DE-B9 for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 02:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1614824700804 (code B ref -1); Thu, 04 Mar 2021 02:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Mar 2021 02:25:00 +0000 Original-Received: from localhost ([127.0.0.1]:57336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHdfg-0000Ct-B0 for submit@debbugs.gnu.org; Wed, 03 Mar 2021 21:25:00 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:60718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHdfe-0000Cl-NW for submit@debbugs.gnu.org; Wed, 03 Mar 2021 21:24:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHdfe-0002mn-HY for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:24:58 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHdfc-0000Ru-Io for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 21:24:58 -0500 X-Originating-IP: 24.113.169.116 Original-Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2BA45C0004 for ; Thu, 4 Mar 2021 02:24:49 +0000 (UTC) Received-SPF: pass client-ip=217.70.183.198; envelope-from=matt@rfc20.org; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201350 Archived-At: --=-=-= Content-Type: text/plain `kill-buffer' was an oddball function. With this patch it is less so. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Call-the-set_buffer_overlays_-setters.patch >From dfe95ffc6a091d44a22854344f43215074a8fe05 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Wed, 3 Mar 2021 16:02:52 -0800 Subject: [PATCH] Call the set_buffer_overlays_ setters Apart from the setters themselves, this is the only place the fields were set directly. * src/buffer.c (Fkill_buffer): Call set_buffer_overlays_before and set_buffer_overlays_after instead of setting the fields directly. --- src/buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/buffer.c b/src/buffer.c index 5bd9b37702..03c10cc7ae 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1942,8 +1942,8 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0, 1, "bKill buffer: ", } /* Since we've unlinked the markers, the overlays can't be here any more either. */ - b->overlays_before = NULL; - b->overlays_after = NULL; + set_buffer_overlays_before (b, NULL); + set_buffer_overlays_after (b, NULL); /* Reset the local variables, so that this buffer's local values won't be protected from GC. They would be protected -- 2.30.0 --=-=-=--