* bug#48145: Quoting of when argument in expansion of declare obsolete
@ 2021-05-01 17:12 Glenn Morris
2021-05-02 7:03 ` Lars Ingebrigtsen
2022-06-17 16:13 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2021-05-01 17:12 UTC (permalink / raw)
To: 48145
Package: emacs
Version: 28.0.50
Severity: wishlist
I noticed statements like these in loaddefs.el, and found the quoting of
the final WHEN argument a bit unexpected:
(make-obsolete 'gnus-intersection 'seq-intersection '"28.1")
I guess it is because of how byte-run--set-obsolete (and friends) is defined.
Does it need to quote the `when' argument, since `when' is documented to
be a string?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48145: Quoting of when argument in expansion of declare obsolete
2021-05-01 17:12 bug#48145: Quoting of when argument in expansion of declare obsolete Glenn Morris
@ 2021-05-02 7:03 ` Lars Ingebrigtsen
2022-06-17 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 16:46 ` Andreas Schwab
2022-06-17 16:13 ` Lars Ingebrigtsen
1 sibling, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-02 7:03 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48145
Glenn Morris <rgm@gnu.org> writes:
> I noticed statements like these in loaddefs.el, and found the quoting of
> the final WHEN argument a bit unexpected:
>
> (make-obsolete 'gnus-intersection 'seq-intersection '"28.1")
>
> I guess it is because of how byte-run--set-obsolete (and friends) is defined.
> Does it need to quote the `when' argument, since `when' is documented to
> be a string?
Grepping through the tree, we seem to have no non-string `when's, so
removing the ' should be safe.
We could also tweak things like
(function-put 'defmethod 'doc-string-elt '3)
I guess...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48145: Quoting of when argument in expansion of declare obsolete
2021-05-01 17:12 bug#48145: Quoting of when argument in expansion of declare obsolete Glenn Morris
2021-05-02 7:03 ` Lars Ingebrigtsen
@ 2022-06-17 16:13 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-17 16:13 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48145
Glenn Morris <rgm@gnu.org> writes:
> I noticed statements like these in loaddefs.el, and found the quoting of
> the final WHEN argument a bit unexpected:
>
> (make-obsolete 'gnus-intersection 'seq-intersection '"28.1")
>
> I guess it is because of how byte-run--set-obsolete (and friends) is defined.
> Does it need to quote the `when' argument, since `when' is documented to
> be a string?
I've now changed it to not quote the when in Emacs 29 -- doesn't seem to
have any odd side effects as far as I can tell.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48145: Quoting of when argument in expansion of declare obsolete
2021-05-02 7:03 ` Lars Ingebrigtsen
@ 2022-06-17 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 17:11 ` Lars Ingebrigtsen
2022-06-17 16:46 ` Andreas Schwab
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-06-17 16:32 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Glenn Morris, 48145
> We could also tweak things like
>
> (function-put 'defmethod 'doc-string-elt '3)
Indeed, this should also refrain from quoting.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48145: Quoting of when argument in expansion of declare obsolete
2021-05-02 7:03 ` Lars Ingebrigtsen
2022-06-17 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-06-17 16:46 ` Andreas Schwab
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2022-06-17 16:46 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Glenn Morris, 48145
On Mai 02 2021, Lars Ingebrigtsen wrote:
> Grepping through the tree, we seem to have no non-string `when's, so
> removing the ' should be safe.
It's not a matter of being a string or not, but whether it is a
self-evaluating expression or not.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#48145: Quoting of when argument in expansion of declare obsolete
2022-06-17 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-06-17 17:11 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-17 17:11 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Glenn Morris, 48145
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> We could also tweak things like
>>
>> (function-put 'defmethod 'doc-string-elt '3)
>
> Indeed, this should also refrain from quoting.
Now fixed.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-17 17:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01 17:12 bug#48145: Quoting of when argument in expansion of declare obsolete Glenn Morris
2021-05-02 7:03 ` Lars Ingebrigtsen
2022-06-17 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-17 17:11 ` Lars Ingebrigtsen
2022-06-17 16:46 ` Andreas Schwab
2022-06-17 16:13 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).