Package: emacs Version: 28.0.50 Severity: wishlist I noticed statements like these in loaddefs.el, and found the quoting of the final WHEN argument a bit unexpected: (make-obsolete 'gnus-intersection 'seq-intersection '"28.1") I guess it is because of how byte-run--set-obsolete (and friends) is defined. Does it need to quote the `when' argument, since `when' is documented to be a string?
Glenn Morris <rgm@gnu.org> writes: > I noticed statements like these in loaddefs.el, and found the quoting of > the final WHEN argument a bit unexpected: > > (make-obsolete 'gnus-intersection 'seq-intersection '"28.1") > > I guess it is because of how byte-run--set-obsolete (and friends) is defined. > Does it need to quote the `when' argument, since `when' is documented to > be a string? Grepping through the tree, we seem to have no non-string `when's, so removing the ' should be safe. We could also tweak things like (function-put 'defmethod 'doc-string-elt '3) I guess... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
Glenn Morris <rgm@gnu.org> writes: > I noticed statements like these in loaddefs.el, and found the quoting of > the final WHEN argument a bit unexpected: > > (make-obsolete 'gnus-intersection 'seq-intersection '"28.1") > > I guess it is because of how byte-run--set-obsolete (and friends) is defined. > Does it need to quote the `when' argument, since `when' is documented to > be a string? I've now changed it to not quote the when in Emacs 29 -- doesn't seem to have any odd side effects as far as I can tell. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
> We could also tweak things like
>
> (function-put 'defmethod 'doc-string-elt '3)
Indeed, this should also refrain from quoting.
Stefan
On Mai 02 2021, Lars Ingebrigtsen wrote:
> Grepping through the tree, we seem to have no non-string `when's, so
> removing the ' should be safe.
It's not a matter of being a string or not, but whether it is a
self-evaluating expression or not.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Stefan Monnier <monnier@iro.umontreal.ca> writes: >> We could also tweak things like >> >> (function-put 'defmethod 'doc-string-elt '3) > > Indeed, this should also refrain from quoting. Now fixed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no