unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, 51891@debbugs.gnu.org
Subject: bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X
Date: Thu, 18 Nov 2021 17:17:25 +0800	[thread overview]
Message-ID: <87zgq1q0uy.fsf@yahoo.com> (raw)
In-Reply-To: <83tug9yl28.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Nov 2021 09:33:51 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> A Lisp object could have different types, one each for every use case
> we want to support.  For example, we could use a single object there,
> which in your case will be a list of 2 values, and in other cases will
> have more members.  We do this kind of stuff all the time, including
> in specifying POSITION in various events -- there are a gazillion of
> different forms of POSITION already in Emacs.  I see no reason to
> change the format when all we need to do is add one more form of
> POSITION.

That makes sense, I'll modify the change in a bit to report scroll
deltas as a pair of (DELTA-X . DELTA-Y) instead.

> Sorry, I don't understand: XInput2 knows about FRAME_PIXEL_HEIGHT of
> our frames?

Indeed it does.  It's the window server, after all.

>> An amount of scrolling that would previously generate a `mouse-4' or
>> `mouse-5' event.

> That doesn't really answer my question.  Let me ask it differently:
> how does "scroll unit" differ from "every time the wheel is moved"?

Basically, even tiny movements of the scroll wheel will cause XInput 2
to generate wheel events.  This makes the behavior stay like the
original by default, where you have to scroll 96 or so pixels before a
wheel event is actually sent.  (This is generally true, but certain mice
may behave differently.)

> I might have ideas once I understand what you are trying to say ;-)

Thanks, I hope what I just said clears things up a bit.





  reply	other threads:[~2021-11-18  9:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zgq4uvh0.fsf.ref@yahoo.com>
2021-11-16 12:38 ` bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-16 13:39   ` Robert Pluim
2021-11-17  0:34     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-17  2:38       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-17 13:33         ` Eli Zaretskii
2021-11-18  0:15           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-18  7:33             ` Eli Zaretskii
2021-11-18  9:17               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-18 10:27                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:05                   ` Eli Zaretskii
2021-11-19 13:10                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:23                       ` Eli Zaretskii
2021-11-20  0:30                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-20  7:06                           ` Eli Zaretskii
2021-11-19 13:09                 ` Eli Zaretskii
2021-11-19 13:24                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:55                     ` Eli Zaretskii
2021-11-20 10:28                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgq1q0uy.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=51891@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).