From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: rpluim@gmail.com, 51891@debbugs.gnu.org
Subject: bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X
Date: Wed, 17 Nov 2021 15:33:29 +0200 [thread overview]
Message-ID: <83r1bezz2u.fsf@gnu.org> (raw)
In-Reply-To: <871r3ftsjy.fsf@yahoo.com> (bug-gnu-emacs@gnu.org)
> Cc: 51891@debbugs.gnu.org
> Date: Wed, 17 Nov 2021 10:38:41 +0800
> From: Po Lu via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> --- a/doc/lispref/commands.texi
> +++ b/doc/lispref/commands.texi
> @@ -1985,7 +1985,11 @@ Misc Events
> These kinds of event are generated by moving a mouse wheel. The
> @var{position} element is a mouse position list (@pxref{Click
> Events}), specifying the position of the mouse cursor when the event
> -occurred.
> +occurred. The event may have additional arguments after
> +@var{position}. The third argument after @var{position}, if present,
> +is a property list of the form @w{@code{(:delta-x @var{x} :delta-y
> +@var{y})}}, where @var{x} and @var{y} are the number of pixels to
> +scroll by in each axis.
Did you consider the possibility of defining a new event?
And should mwheel.el be aware of this change somehow?
And finally, why introduce keyword-value pairs into a form that didn't
use them before? Can we store just the values there?
> + scroll_unit = pow (FRAME_PIXEL_HEIGHT (f), 2.0 / 3.0);
Ouch! can we avoid calling 'pow' here? It's an expensive function.
> + DEFVAR_BOOL ("x-coalesce-scroll-events", x_coalesce_scroll_events,
> + doc: /* Non-nil means to only send one wheel event for each scroll unit.
> +Otherwise, a wheel event will be sent every time the mouse wheel is
> +moved.
This is confusing: what does "scroll unit" mean in this context?
next prev parent reply other threads:[~2021-11-17 13:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87zgq4uvh0.fsf.ref@yahoo.com>
2021-11-16 12:38 ` bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-16 13:39 ` Robert Pluim
2021-11-17 0:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-17 2:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-17 13:33 ` Eli Zaretskii [this message]
2021-11-18 0:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-18 7:33 ` Eli Zaretskii
2021-11-18 9:17 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-18 10:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:05 ` Eli Zaretskii
2021-11-19 13:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:23 ` Eli Zaretskii
2021-11-20 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-20 7:06 ` Eli Zaretskii
2021-11-19 13:09 ` Eli Zaretskii
2021-11-19 13:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 13:55 ` Eli Zaretskii
2021-11-20 10:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r1bezz2u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51891@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).