From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X Date: Thu, 18 Nov 2021 17:17:25 +0800 Message-ID: <87zgq1q0uy.fsf@yahoo.com> References: <87zgq4uvh0.fsf.ref@yahoo.com> <87zgq4uvh0.fsf@yahoo.com> <871r3gnrrn.fsf@gmail.com> <875ysrtyak.fsf@yahoo.com> <871r3ftsjy.fsf@yahoo.com> <83r1bezz2u.fsf@gnu.org> <87r1beqpy8.fsf@yahoo.com> <83tug9yl28.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30289"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: rpluim@gmail.com, 51891@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 10:18:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mndYa-0007eF-J0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 10:18:12 +0100 Original-Received: from localhost ([::1]:53356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mndYZ-0007hH-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 04:18:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mndYR-0007gD-7m for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 04:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mndYQ-0002l1-Vl for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 04:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mndYQ-0006vA-Rm for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 04:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51891-submit@debbugs.gnu.org id=B51891.163722706526553 (code B ref 51891); Thu, 18 Nov 2021 09:18:02 +0000 Original-Received: (at 51891) by debbugs.gnu.org; 18 Nov 2021 09:17:45 +0000 Original-Received: from localhost ([127.0.0.1]:34722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mndY8-0006uC-Qq for submit@debbugs.gnu.org; Thu, 18 Nov 2021 04:17:45 -0500 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:36660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mndY5-0006ta-Jq for 51891@debbugs.gnu.org; Thu, 18 Nov 2021 04:17:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637227056; bh=x/Z04ibMekc842tCjH8TWlGtc4yCYtAPIixDQWgKCGU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=cXbVATymL80NokimItSTb2byqfybcHg1gnTSI9KQsO3PppR3cbwl7sFEDFcG2UIt06PE1PknhJopofmOzppsCXxzbrSqya7dnEpABe0wQHCdg31MY9FzEm3GLv8Tij4WPn2j9sOv0PJ3TIkyLLRPc4G5Occfl1uoisG+I1sDR1QNoJHDH590T4tSyyIcuzDssg30WhYujIU+nwDy0w5ZDmQULZxIC87QPverfouDcq1ibeDjt7ND1myoLXQ0orf02AXmC7ojwbbB8mxktl67dw1gpZ9BgkCSn3hDaXM0+6wTmcQLys4Hq89R0O+8eGDPqUJiUIM1YkPGvfZpUUjCRQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637227056; bh=INqIL3s7OCU8ULDVRKRA+ow0Ttxci+b1lamnjoLBYO+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fxFp0i5SOTtRU1+xp9amELLPS2dfOh/iPu0iU3X+7kkblWVsNMU6wl1+hvQDWwblqEgUaDruoCCDyJnPCDaWHLY66nODTCrUT+/ApHNJ0o/cqGkqvNZ1VC3JB0DvqVrB43mEOudCr5eaYn5Ub9S6FZ0ViG25Y8Dcxd9Z0ul97ddmOcuSgbmJIkgp9FlWVWSFR7kcQhytj3eo2H8evCnXwmSMuu7yxzIVk2jGgySlSPFT/s8VfoYNaBEnJWiJNrotIT2cxTGj1IyfJFUqbpOst/A6o2JMXeSvSuVNVcTZxU7mJ9juUcNtwY3ecNTQTxLob/QSOxGfAMo4KeH1bDVLSg== X-YMail-OSG: _mICJNQVM1m.RxcCAoZQGEyKabySIBdPZ2_V_6AUYo6nJgUQ5imNLG76nB8cqZF TeTbJocLlR1tBr2ZmscLoygOedt.UfdTnrb838iwRfptuPzKuQvR8kREVCzc_cUyDCQju9Hm3GwD nfr9vjt4kCjDM7JrluqFLP3ahsvdp3uCNdJlZM2JwI9fhwv_FjhxxQToaAne5XJFQjS6mzmHoTW_ b0tJUalK.V.hPYypjdYHLZTxH.AS1KgZvNnnSIGWzHbDjnS2rJG3JDU7VwWfgnO7EfRGHw0HGMH8 EViCbM5tBppU3OSvjbFBXiJiSlUlerKtH0ARayTCj82jGGuMKFxLqsvw53gHZ8shX84m4_LnElO1 8wmpscku6s2O3MZfPnTbDhV6M4MJZELcO.yhM2w2a7mWW7FbuZZB8iKlNClRRvHSarsx7B3P3nKH EVYw5fAo_c_za_FD6nSzq1S_7whi6lMwHRHgg8atepMWSt.MYDwhFhHy9KG.P0MqgcDDIBS6fmOr _q8SQCwg1XopPeqLErXRoO3Aw3ndA9TJtxTTvCdsGr2n.RS_CagMUxdi7hC_69JOVGGXuWQzQ_Jx o80k3l_XrGlBRyMbTCvd.AWFdDUA7mdLfyl4lZwlwzu6uPAcjOAf_SMzMYIfA75ovL0yGSqnd9_8 fxYqH9GHb8rfv42NIF5522uvYsHwN.JzuRCussoGOHbHEtnfPBH8EiwN4qFd9LJg1GG9rSWlPHhT bQXXOs03_zCd1AmB.cC590OcdHSDjrpEpujFXZDFOcjJ2WXsyf4kaZg4yZRQOYxuwKqKbrrp8rL5 Ys.Bz1kjF7hhhjIvJGTy8TasQ84wRDfpiLDy2XTU69 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Thu, 18 Nov 2021 09:17:36 +0000 Original-Received: by kubenode516.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 608cd43796cb626606981c79ae0cfeab; Thu, 18 Nov 2021 09:17:29 +0000 (UTC) In-Reply-To: <83tug9yl28.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Nov 2021 09:33:51 +0200") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220278 Archived-At: Eli Zaretskii writes: > A Lisp object could have different types, one each for every use case > we want to support. For example, we could use a single object there, > which in your case will be a list of 2 values, and in other cases will > have more members. We do this kind of stuff all the time, including > in specifying POSITION in various events -- there are a gazillion of > different forms of POSITION already in Emacs. I see no reason to > change the format when all we need to do is add one more form of > POSITION. That makes sense, I'll modify the change in a bit to report scroll deltas as a pair of (DELTA-X . DELTA-Y) instead. > Sorry, I don't understand: XInput2 knows about FRAME_PIXEL_HEIGHT of > our frames? Indeed it does. It's the window server, after all. >> An amount of scrolling that would previously generate a `mouse-4' or >> `mouse-5' event. > That doesn't really answer my question. Let me ask it differently: > how does "scroll unit" differ from "every time the wheel is moved"? Basically, even tiny movements of the scroll wheel will cause XInput 2 to generate wheel events. This makes the behavior stay like the original by default, where you have to scroll 96 or so pixels before a wheel event is actually sent. (This is generally true, but certain mice may behave differently.) > I might have ideas once I understand what you are trying to say ;-) Thanks, I hope what I just said clears things up a bit.