From: Chong Yidong <cyd@stupidchicken.com>
To: Juri Linkov <juri@jurta.org>
Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' <larsi@gnus.org>,
jidanni@jidanni.org
Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Wed, 17 Aug 2011 17:36:10 -0400 [thread overview]
Message-ID: <87y5yrwwj9.fsf@stupidchicken.com> (raw)
In-Reply-To: <87ippvhm3g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 17 Aug 2011 22:35:45 +0300")
Juri Linkov <juri@jurta.org> writes:
> In the patch below, I've removed the regression and restored
> traditional pre-24 colors in compilation and dired, and also changed
> `dired-flagged' to inherit from the `error' face, and `dired-marked'
> from `warning'.
>
> There are more places that need these new faces to indicate
> error/warning/success, e.g. battery.el and other packages unrelated to
> font-lock that currently abuse font-lock faces. They could be
> modified later.
Looks fine to me, but test the 16-color versions of those faces in an
xterm first, to see if those color values give the right results.
next prev parent reply other threads:[~2011-08-17 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 20:31 bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni
2010-05-06 13:17 ` Stefan Monnier
2010-05-06 15:20 ` Drew Adams
2011-07-13 21:28 ` Lars Magne Ingebrigtsen
2011-07-13 22:28 ` Drew Adams
2011-07-16 19:53 ` Lars Magne Ingebrigtsen
2011-08-02 19:05 ` Lars Magne Ingebrigtsen
2011-08-10 9:45 ` Juri Linkov
2011-08-10 13:45 ` Drew Adams
2011-08-17 19:35 ` Juri Linkov
2011-08-17 21:36 ` Chong Yidong [this message]
2011-08-18 11:46 ` Juri Linkov
2011-08-24 18:09 ` Juri Linkov
2011-08-24 18:16 ` Drew Adams
2010-05-06 20:57 ` Juri Linkov
2010-05-07 2:43 ` Drew Adams
2010-05-07 18:16 ` Juri Linkov
2010-05-10 18:45 ` bug#6163: 24.0.50; be sure the color of the mark matches that of the filename jidanni
2011-08-02 16:00 ` Lars Magne Ingebrigtsen
2011-08-17 20:02 ` bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5yrwwj9.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=6117@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
--cc=juri@jurta.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).