From: Juri Linkov <juri@jurta.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' <larsi@gnus.org>,
jidanni@jidanni.org
Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Thu, 18 Aug 2011 14:46:25 +0300 [thread overview]
Message-ID: <87vctv54dq.fsf@mail.jurta.org> (raw)
In-Reply-To: <87y5yrwwj9.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 17 Aug 2011 17:36:10 -0400")
> Looks fine to me, but test the 16-color versions of those faces in an
> xterm first, to see if those color values give the right results.
Done.
I tested the 16-color versions in an xterm, and they look fine
on light and dark backgrounds.
I'm also going to install changes in packages related to dired
that use faces for marked/flagged for deletion:
=== modified file 'lisp/ibuffer.el'
--- lisp/ibuffer.el 2011-08-15 10:21:47 +0000
+++ lisp/ibuffer.el 2011-08-18 11:20:35 +0000
@@ -356,12 +356,12 @@ (defcustom ibuffer-load-hook nil
:type 'hook
:group 'ibuffer)
-(defcustom ibuffer-marked-face 'font-lock-warning-face
+(defcustom ibuffer-marked-face 'warning
"Face used for displaying marked buffers."
:type 'face
:group 'ibuffer)
-(defcustom ibuffer-deletion-face 'font-lock-type-face
+(defcustom ibuffer-deletion-face 'error
"Face used for displaying buffers marked for deletion."
:type 'face
:group 'ibuffer)
=== modified file 'lisp/proced.el'
--- lisp/proced.el 2011-07-20 09:53:51 +0000
+++ lisp/proced.el 2011-08-18 11:29:33 +0000
@@ -395,7 +395,7 @@ (defface proced-mark
:group 'proced-faces)
(defface proced-marked
- '((t (:inherit font-lock-warning-face)))
+ '((t (:inherit error)))
"Face used for marked processes."
:group 'proced-faces)
=== modified file 'lisp/battery.el'
--- lisp/battery.el 2011-06-27 08:04:55 +0000
+++ lisp/battery.el 2011-08-18 11:12:33 +0000
@@ -199,7 +199,7 @@ (defun battery-update ()
'face
(and (<= (car (read-from-string (cdr (assq ?p data))))
battery-load-critical)
- 'font-lock-warning-face)
+ 'error)
'help-echo "Battery status information")))
(force-mode-line-update))
\f
next prev parent reply other threads:[~2011-08-18 11:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 20:31 bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni
2010-05-06 13:17 ` Stefan Monnier
2010-05-06 15:20 ` Drew Adams
2011-07-13 21:28 ` Lars Magne Ingebrigtsen
2011-07-13 22:28 ` Drew Adams
2011-07-16 19:53 ` Lars Magne Ingebrigtsen
2011-08-02 19:05 ` Lars Magne Ingebrigtsen
2011-08-10 9:45 ` Juri Linkov
2011-08-10 13:45 ` Drew Adams
2011-08-17 19:35 ` Juri Linkov
2011-08-17 21:36 ` Chong Yidong
2011-08-18 11:46 ` Juri Linkov [this message]
2011-08-24 18:09 ` Juri Linkov
2011-08-24 18:16 ` Drew Adams
2010-05-06 20:57 ` Juri Linkov
2010-05-07 2:43 ` Drew Adams
2010-05-07 18:16 ` Juri Linkov
2010-05-10 18:45 ` bug#6163: 24.0.50; be sure the color of the mark matches that of the filename jidanni
2011-08-02 16:00 ` Lars Magne Ingebrigtsen
2011-08-17 20:02 ` bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vctv54dq.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=6117@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=jidanni@jidanni.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).