unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Fri, 07 May 2010 21:16:12 +0300	[thread overview]
Message-ID: <87vdazakrb.fsf@mail.jurta.org> (raw)
In-Reply-To: <4E9293AAC84E40FE9331FD9DE354AB06@us.oracle.com> (Drew Adams's message of "Thu, 6 May 2010 19:43:10 -0700")

> There is definitely a difference, even for you, between * and D marks.
> Commands such as B, C, and M have no effect on D marks (flags), but they
> do affect * marks.

I meant that the difference between marking and flagging is artificial.
There are just different keys to do the same: `D' for marked "*" files,
and `x' for flagged "D" files.

> * and D have different behavior and they should definitely have
> different faces with different default colors.

I don't oppose different default faces.  I only had a doubt if users
would like that.  However, when decided to use different faces,
I suggest to use the following default faces:

* for `dired-flagged' leave the current face unchanged, inherited
  from `font-lock-warning-face' just like `compilation-error';

* for `dired-marked' use the same face definition as for
  `compilation-warning'.  This face is closer to the current
  `font-lock-warning-face'.

-- 
Juri Linkov
http://www.jurta.org/emacs/






  reply	other threads:[~2010-05-07 18:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 20:31 bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni
2010-05-06 13:17 ` Stefan Monnier
2010-05-06 15:20   ` Drew Adams
2011-07-13 21:28   ` Lars Magne Ingebrigtsen
2011-07-13 22:28     ` Drew Adams
2011-07-16 19:53     ` Lars Magne Ingebrigtsen
2011-08-02 19:05       ` Lars Magne Ingebrigtsen
2011-08-10  9:45         ` Juri Linkov
2011-08-10 13:45           ` Drew Adams
2011-08-17 19:35             ` Juri Linkov
2011-08-17 21:36               ` Chong Yidong
2011-08-18 11:46                 ` Juri Linkov
2011-08-24 18:09                   ` Juri Linkov
2011-08-24 18:16                     ` Drew Adams
2010-05-06 20:57 ` Juri Linkov
2010-05-07  2:43   ` Drew Adams
2010-05-07 18:16     ` Juri Linkov [this message]
2010-05-10 18:45 ` bug#6163: 24.0.50; be sure the color of the mark matches that of the filename jidanni
2011-08-02 16:00   ` Lars Magne Ingebrigtsen
2011-08-17 20:02 ` bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face jidanni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdazakrb.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=6117@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).