From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails Date: Sat, 03 Dec 2016 17:38:36 -0500 Message-ID: <87y3zwfxjn.fsf@users.sourceforge.net> References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480804691 19685 195.159.176.226 (3 Dec 2016 22:38:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Dec 2016 22:38:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25088@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 03 23:38:07 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDIwZ-0004Rm-Ee for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Dec 2016 23:38:07 +0100 Original-Received: from localhost ([::1]:52697 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDIwd-0000Za-3n for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Dec 2016 17:38:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDIwX-0000ZK-AB for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 17:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDIwU-0006qz-6h for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 17:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDIwU-0006qs-3X for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 17:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cDIwT-0004nT-P4 for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2016 17:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Dec 2016 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25088-submit@debbugs.gnu.org id=B25088.148080466618416 (code B ref 25088); Sat, 03 Dec 2016 22:38:01 +0000 Original-Received: (at 25088) by debbugs.gnu.org; 3 Dec 2016 22:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:51708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDIwD-0004my-SO for submit@debbugs.gnu.org; Sat, 03 Dec 2016 17:37:46 -0500 Original-Received: from mail-io0-f169.google.com ([209.85.223.169]:33255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDIwC-0004mk-IQ for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 17:37:44 -0500 Original-Received: by mail-io0-f169.google.com with SMTP id j65so540323989iof.0 for <25088@debbugs.gnu.org>; Sat, 03 Dec 2016 14:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4B+0Mu9EKipIf8xvyq1rcMPi2IZ8kR8Tgc8OIbwFaaY=; b=O+U1RIreGstzAgpaFk3yxPGewJQKwKeDhy+znFuI3OudX/EIJatYVV3mClQ34Cbj7x 8rB/hCUDZhVvNcalBs8xOLGKPAka68jvCCHox1Rf2HVLRScCNNzejvvh2+v0kA+ZyURD aujd0f3yKGiYpp0w1lpDfD9pcdxv1IzU+c6SgZch5zqpqyx34Exg6hjsXEMTYJp8R2Sn ZY7VRryyRc6lPEKM7x2S0h+ogC02JYqGiu/ckHAEZTH13gdA+1pSIyinB9PxopVJC/PS h/Ii0c56n1Zu5lX9dCvoe4YVzoxSy8eMWZUFrNKQ+gfMQxc2aG1zP+USBpxEDdnnDcuC WZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4B+0Mu9EKipIf8xvyq1rcMPi2IZ8kR8Tgc8OIbwFaaY=; b=fYTM6zO1fv1je9KkY2xTxVn3laUTe2RLPI8OHw0/fJ4LrQcuB3KhqJ7cUlCgnnmobA 0LY3sfalxpDS5MZaj0G4gzbDWeo+gFCOILtAatB1R4ZUVSJDxV/zrXGqvg28JmwtTzaX MLToObRoFZs44rcoIWbDPPiNJwuffnrU5Cmsug9qIKxnDepBQjbcEwHsz7q5NE4iW/F8 Fx4xR6+LB5FMK5caYJebE5WNDxF9ewpp3pdL3e6qAsCd2gCwwk4En9kzprK64fRQAXBA tRYIXf6WRt0jbI4gSTVJX9aj/tTRLye2zvQFNDewmhQODum2RJQKzrRLuyBx95gdk34W 1dxw== X-Gm-Message-State: AKaTC01ohsO4CwMa0ltfcFoVRDuppnPxzSy3HGLjjVAveIXBWqYRzvpfmLFajo7kTOe9aA== X-Received: by 10.36.80.145 with SMTP id m139mr3088334itb.24.1480804658808; Sat, 03 Dec 2016 14:37:38 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 9sm4113021itv.0.2016.12.03.14.37.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Dec 2016 14:37:38 -0800 (PST) In-Reply-To: <83eg1qoiiv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Dec 2016 10:13:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126461 Archived-At: Eli Zaretskii writes: > > How risky is this change? cl-defstruct is a very widely used macro, > whereas unload-feature is a relatively obscure feature. Is it really > worth fixing the (IMO minor) error and risking to break Emacs 25.2? > > I don't have an intuition I can trust in these matters, so I need you > and others who do to offer their opinions, after carefully considering > the pros and cons. I think it's safe, but I've been wrong before. I agree that unload-feature is sufficiently obscure that this can go to master instead of emacs-25. Perhaps the real bug is that unload-feature doesn't undo `put', thus the compiler-macro still hangs around.