unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Van L <van@scratch.space>, 33398@debbugs.gnu.org
Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
Date: Tue, 27 Nov 2018 01:27:40 +0200	[thread overview]
Message-ID: <87y39fmnbn.fsf@mail.linkov.net> (raw)
In-Reply-To: <83h8g3j0aa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Nov 2018 18:01:17 +0200")

> So your problem is with the names of the faces?  Then may I suggest to
> name the new faces hi-red and hi-deepblue?

Maybe something like this, but I'm not sure because the red background would
be too glaring on 88 colors, but more readable orchid1 is not quite red.
Also blue would be too dark for a light background, but more readable
DarkSlateGray1 is not quite blue as its name suggests.

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index f503c2764b..223b1007a8 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -177,6 +177,24 @@ hi-blue
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
+(defface hi-red
+  '((((min-colors 88) (background dark))
+     (:background "orchid1" :foreground "black"))
+    (((background dark)) (:background "red" :foreground "black"))
+    (((min-colors 88)) (:background "orchid1"))
+    (t (:background "red")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
+(defface hi-deepblue
+  '((((min-colors 88) (background dark))
+     (:background "DarkSlateGray1" :foreground "black"))
+    (((background dark)) (:background "blue" :foreground "black"))
+    (((min-colors 88)) (:background "DarkSlateGray1"))
+    (t (:background "blue")))
+  "Face for hi-lock mode."
+  :group 'hi-lock-faces)
+
 (defface hi-black-b
   '((t (:weight bold)))
   "Face for hi-lock mode."
@@ -189,13 +207,13 @@ hi-blue-b
   :group 'hi-lock-faces)
 
 (defface hi-green-b
-  '((((min-colors 88)) (:weight bold :foreground "green1"))
+  '((((min-colors 88)) (:weight bold :foreground "green3"))
     (t (:weight bold :foreground "green")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-red-b
-  '((((min-colors 88)) (:weight bold :foreground "red1"))
+  '((((min-colors 88)) (:weight bold :foreground "firebrick2"))
     (t (:weight bold :foreground "red")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
@@ -216,8 +234,8 @@ hi-lock-interactive-patterns
 (define-obsolete-variable-alias 'hi-lock-face-history
                                 'hi-lock-face-defaults "23.1")
 (defvar hi-lock-face-defaults
-  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-black-b"
-    "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
+  '("hi-yellow" "hi-pink" "hi-green" "hi-blue" "hi-red" "hi-deepblue"
+    "hi-black-b" "hi-blue-b" "hi-red-b" "hi-green-b" "hi-black-hb")
   "Default faces for hi-lock interactive functions.")
 
 (define-obsolete-variable-alias 'hi-lock-regexp-history





  reply	other threads:[~2018-11-26 23:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 12:58 bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Van L
2018-11-15 21:25 ` Juri Linkov
2018-11-15 22:13   ` Van L
2018-11-17 20:54     ` Juri Linkov
2018-11-19  3:10       ` Van L
2018-11-19 21:58         ` Juri Linkov
2018-11-20  4:00           ` Van L
2018-11-20 22:59             ` Juri Linkov
2018-11-21 12:23               ` Van L
2018-11-21 22:56                 ` Juri Linkov
2018-11-22  0:32                   ` Van L
2018-11-22 22:16                     ` Juri Linkov
2018-11-23  0:56                       ` Van L
2018-11-23  8:38                         ` Eli Zaretskii
2018-11-23 11:22                           ` Van L
2018-11-23 15:54                             ` Eli Zaretskii
2018-11-23  8:35                       ` Eli Zaretskii
2018-11-24 21:29                         ` Juri Linkov
2018-11-25 16:46                           ` Eli Zaretskii
2018-11-25 20:25                             ` Juri Linkov
2018-11-26 16:01                               ` Eli Zaretskii
2018-11-26 23:27                                 ` Juri Linkov [this message]
2018-11-27  5:56                                   ` Eli Zaretskii
2018-11-27 23:49                                     ` Juri Linkov
2018-11-28 23:06                                       ` Juri Linkov
2018-11-29  7:32                                         ` Eli Zaretskii
2018-11-29 22:29                                           ` Juri Linkov
2018-11-30  7:16                                             ` Eli Zaretskii
2018-12-19  0:36                                               ` Juri Linkov
2018-12-19  3:50                                                 ` Van L
2018-12-19 21:37                                                   ` Juri Linkov
2018-12-19 15:19                                                 ` Eli Zaretskii
2018-12-19 21:40                                                   ` Juri Linkov
2018-12-20  0:16                                                     ` Van L
2018-12-20 16:11                                                     ` Eli Zaretskii
2018-12-20 23:01                                                       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y39fmnbn.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=33398@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=van@scratch.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).