From: Lars Ingebrigtsen <larsi@gnus.org>
To: thunk2@arcor.de (Thomas Plass)
Cc: 34315@debbugs.gnu.org
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Date: Wed, 12 Aug 2020 15:12:27 +0200 [thread overview]
Message-ID: <87y2mkknyc.fsf@gnus.org> (raw)
In-Reply-To: <24371.59842.984273.402129@AGAME7.local> (Thomas Plass's message of "Wed, 12 Aug 2020 15:08:18 +0200")
thunk2@arcor.de (Thomas Plass) writes:
> Attached is an updated ZIP containing the respun patch and the
> unmodified samples. The patch is against
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el
> blob: d76c11050312b4a04ac1cbda436b3c08fc6f2cc5
>
> Hopefully, this is OK as it is.
It would be better to add the test cases in the test/data directory and
add the tests as code to icalendar-tests.el...
> : Thomas, could you please provide the expected results for the test files,
> : one for each ics file? Thanks!
>
> Well, the expected result depends on:
>
> - The local timezone of the person running the code. Where I'm
> sitting, it is November 3, 2018 20:15h for all samples.
(etc)
This is why the test cases should bind the time zone to whatever it is
it's testing -- that way we can easily ensure that the code continues to
work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-12 13:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 11:48 bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Thomas Plass
2019-02-12 18:57 ` Ulf Jasper
2019-02-15 17:17 ` Ulf Jasper
2019-02-18 9:36 ` Thomas Plass
2019-02-18 15:59 ` Eli Zaretskii
2019-02-18 19:15 ` Thomas Plass
2019-02-18 19:30 ` Eli Zaretskii
2019-02-18 20:03 ` Thomas Plass
2019-02-18 20:16 ` Eli Zaretskii
2020-08-10 11:48 ` Lars Ingebrigtsen
2020-08-10 16:08 ` Ulf Jasper
2020-08-10 16:45 ` Eli Zaretskii
2020-08-10 17:04 ` Thomas Plass
2020-08-11 11:01 ` Lars Ingebrigtsen
2020-08-11 15:14 ` Ulf Jasper
2020-08-11 15:19 ` Lars Ingebrigtsen
2020-08-11 15:45 ` Ulf Jasper
2020-08-12 13:08 ` Thomas Plass
2020-08-12 13:12 ` Lars Ingebrigtsen [this message]
2020-08-12 13:30 ` Thomas Plass
2020-08-12 15:06 ` Ulf Jasper
2020-09-02 18:05 ` Ulf Jasper
2020-09-03 8:38 ` Thomas Plass
2020-09-03 14:28 ` Ulf Jasper
2020-09-12 8:01 ` Thomas Plass
2020-09-12 8:11 ` Eli Zaretskii
2020-09-13 4:07 ` Richard Stallman
2020-09-29 10:05 ` Thomas Plass
2020-10-01 1:45 ` Lars Ingebrigtsen
2020-10-01 1:50 ` Lars Ingebrigtsen
2020-10-01 13:38 ` Thomas Plass
2020-10-01 16:19 ` Ulf Jasper
2020-10-01 16:22 ` Lars Ingebrigtsen
2020-10-01 16:54 ` Ulf Jasper
2020-10-01 16:59 ` Lars Ingebrigtsen
2020-10-01 18:40 ` Ulf Jasper
2020-10-01 18:47 ` Lars Ingebrigtsen
2020-10-01 19:00 ` Ulf Jasper
2020-10-01 18:49 ` Thomas Plass
2020-10-01 18:53 ` Thomas Plass
2020-10-01 19:14 ` Ulf Jasper
2020-10-10 20:06 ` Lars Ingebrigtsen
2020-10-22 15:50 ` Ulf Jasper
2021-05-11 14:10 ` Lars Ingebrigtsen
2021-07-29 14:55 ` Ulf Jasper
2021-07-30 11:37 ` Lars Ingebrigtsen
2023-10-01 2:12 ` Stefan Kangas
2023-10-12 14:49 ` Ulf Jasper
2023-10-15 14:28 ` Stefan Kangas
2023-10-19 14:11 ` Ulf Jasper
2023-12-24 14:02 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2mkknyc.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=34315@debbugs.gnu.org \
--cc=thunk2@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).