From: thunk2@arcor.de (Thomas Plass)
To: Ulf Jasper <ulf.jasper@web.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Thomas Plass <thunk2@arcor.de>,
Jan Tatarik <jan.tatarik@gmail.com>,
34315@debbugs.gnu.org
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Date: Thu, 1 Oct 2020 21:49:06 +0300 [thread overview]
Message-ID: <24438.9378.994810.275603@AGAME7.local> (raw)
In-Reply-To: Your message of Thursday, October 1 2020 18:54:56 (ID: <878scpvqcf.fsf@panama>).
I'd like to get some guidance from people involved on the following proposal:
Ulf Jasper wrote at 18:54 on October 1, 2020:
: Currently there is no way to use ics files in icalendar-tests.
Would it be acceptable to:
- create a directory root/test/lisp/calendar/icalendar-resources
- extend icalendar-tests.el with the following:
(defvar icalendar-resources-directory "icalendar-resources"
"Name of directory containing ICS files.
This directory is relative to icalendar-tests.el.")
(defun icalendar-tests--get-ical-from-file (ics-file &optional component)
"Return iCalendar data structures from ICS-FILE.
Optional symbol COMPONENT names a top-level component like 'VTIMEZONE."
(let (ical)
(if (file-exists-p ics-file)
(save-excursion
(with-temp-buffer
(insert-file-contents ics-file)
(goto-char (point-min))
(setq ical (car (icalendar--read-element nil nil)))
(if component
(setq res (car (icalendar--get-children ical component)))
(setq res ical))))
(error "Can't find ICS file %s" ics-file))))
Which could be used thusly in the definition of 'icalendar--parse-vtimezone:
(ert-deftest icalendar--parse-vtimezone ()
"Test method for `icalendar--parse-vtimezone'."
(let (vtimezone result)
(setq vtimezone (icalendar-tests--get-ical-from-file
(concat (file-name-as-directory icalendar-resources-directory)
"Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics")
'VTIMEZONE))
(setq result (icalendar--parse-vtimezone vtimezone))
(should (string= "Asia/Shanghai" (car result)))
(message (cdr result))
(should (string= "STD-08:00"
(cdr result)))
...
))
I have no idea how the test code is run, in particular how
(concat (file-name-as-directory icalendar-resources-directory)
"Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics")
could be made to resolve.
Also, I cannot alter the git.
Please advise.
next prev parent reply other threads:[~2020-10-01 18:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 11:48 bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Thomas Plass
2019-02-12 18:57 ` Ulf Jasper
2019-02-15 17:17 ` Ulf Jasper
2019-02-18 9:36 ` Thomas Plass
2019-02-18 15:59 ` Eli Zaretskii
2019-02-18 19:15 ` Thomas Plass
2019-02-18 19:30 ` Eli Zaretskii
2019-02-18 20:03 ` Thomas Plass
2019-02-18 20:16 ` Eli Zaretskii
2020-08-10 11:48 ` Lars Ingebrigtsen
2020-08-10 16:08 ` Ulf Jasper
2020-08-10 16:45 ` Eli Zaretskii
2020-08-10 17:04 ` Thomas Plass
2020-08-11 11:01 ` Lars Ingebrigtsen
2020-08-11 15:14 ` Ulf Jasper
2020-08-11 15:19 ` Lars Ingebrigtsen
2020-08-11 15:45 ` Ulf Jasper
2020-08-12 13:08 ` Thomas Plass
2020-08-12 13:12 ` Lars Ingebrigtsen
2020-08-12 13:30 ` Thomas Plass
2020-08-12 15:06 ` Ulf Jasper
2020-09-02 18:05 ` Ulf Jasper
2020-09-03 8:38 ` Thomas Plass
2020-09-03 14:28 ` Ulf Jasper
2020-09-12 8:01 ` Thomas Plass
2020-09-12 8:11 ` Eli Zaretskii
2020-09-13 4:07 ` Richard Stallman
2020-09-29 10:05 ` Thomas Plass
2020-10-01 1:45 ` Lars Ingebrigtsen
2020-10-01 1:50 ` Lars Ingebrigtsen
2020-10-01 13:38 ` Thomas Plass
2020-10-01 16:19 ` Ulf Jasper
2020-10-01 16:22 ` Lars Ingebrigtsen
2020-10-01 16:54 ` Ulf Jasper
2020-10-01 16:59 ` Lars Ingebrigtsen
2020-10-01 18:40 ` Ulf Jasper
2020-10-01 18:47 ` Lars Ingebrigtsen
2020-10-01 19:00 ` Ulf Jasper
2020-10-01 18:49 ` Thomas Plass [this message]
2020-10-01 18:53 ` Thomas Plass
2020-10-01 19:14 ` Ulf Jasper
2020-10-10 20:06 ` Lars Ingebrigtsen
2020-10-22 15:50 ` Ulf Jasper
2021-05-11 14:10 ` Lars Ingebrigtsen
2021-07-29 14:55 ` Ulf Jasper
2021-07-30 11:37 ` Lars Ingebrigtsen
2023-10-01 2:12 ` Stefan Kangas
2023-10-12 14:49 ` Ulf Jasper
2023-10-15 14:28 ` Stefan Kangas
2023-10-19 14:11 ` Ulf Jasper
2023-12-24 14:02 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24438.9378.994810.275603@AGAME7.local \
--to=thunk2@arcor.de \
--cc=34315@debbugs.gnu.org \
--cc=jan.tatarik@gmail.com \
--cc=larsi@gnus.org \
--cc=ulf.jasper@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).