From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Date: Wed, 12 Aug 2020 15:12:27 +0200 Message-ID: <87y2mkknyc.fsf@gnus.org> References: <23640.9851.562972.730234@AGAME7.local> <875ztog7hx.fsf@panama> <87wom1otsw.fsf@panama> <87zh7267sy.fsf@gnus.org> <87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@gnu.org> <24369.32256.954408.774614@AGAME7.local> <87y2mlxx8r.fsf@gnus.org> <87d03x43kz.fsf@panama> <24371.59842.984273.402129@AGAME7.local> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="950"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34315@debbugs.gnu.org To: thunk2@arcor.de (Thomas Plass) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 15:13:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5qZ2-000057-V4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 15:13:08 +0200 Original-Received: from localhost ([::1]:49070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5qZ2-0003g2-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 09:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5qYw-0003fu-7y for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5qYv-00014S-VA for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 09:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5qYv-0002KW-Qg for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 09:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34315-submit@debbugs.gnu.org id=B34315.15972379628930 (code B ref 34315); Wed, 12 Aug 2020 13:13:01 +0000 Original-Received: (at 34315) by debbugs.gnu.org; 12 Aug 2020 13:12:42 +0000 Original-Received: from localhost ([127.0.0.1]:43297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5qYc-0002Jy-FI for submit@debbugs.gnu.org; Wed, 12 Aug 2020 09:12:42 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5qYa-0002Jl-RC for 34315@debbugs.gnu.org; Wed, 12 Aug 2020 09:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ViljQ9/M3gQrZ2h74obprmkiPrVSkYCASRIIBGuI/PE=; b=rI0deQPb87HeDMQuv2+DCN0uxy 04gD903KPqOpj579Phr+Mt2n8Gy5jJqlZHCDVfOnap6I7+rhak5EHeTFADJBhof9wgi0oL5O/bPv/ Ep1y4ZVoNe7IYk7ADEvmnva7wTqIROF1QHj8dFTfMf11dF7w8qinxi1JfYG9lW4FjkU0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5qYP-00011M-6x; Wed, 12 Aug 2020 15:12:34 +0200 In-Reply-To: <24371.59842.984273.402129@AGAME7.local> (Thomas Plass's message of "Wed, 12 Aug 2020 15:08:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184790 Archived-At: thunk2@arcor.de (Thomas Plass) writes: > Attached is an updated ZIP containing the respun patch and the > unmodified samples. The patch is against > https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el > blob: d76c11050312b4a04ac1cbda436b3c08fc6f2cc5 > > Hopefully, this is OK as it is. It would be better to add the test cases in the test/data directory and add the tests as code to icalendar-tests.el... > : Thomas, could you please provide the expected results for the test files, > : one for each ics file? Thanks! > > Well, the expected result depends on: > > - The local timezone of the person running the code. Where I'm > sitting, it is November 3, 2018 20:15h for all samples. (etc) This is why the test cases should bind the time zone to whatever it is it's testing -- that way we can easily ensure that the code continues to work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no