From: Michael Albinus <michael.albinus@gmx.de>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 43412@debbugs.gnu.org
Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Date: Thu, 17 Sep 2020 13:07:02 +0200 [thread overview]
Message-ID: <87y2l8slux.fsf@gmx.de> (raw)
In-Reply-To: <20200915193146.rcrylluhr7ah7dst@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 15 Sep 2020 15:31:47 -0400")
Boruch Baum <boruch_baum@gmx.com> writes:
Hi Boruch,
>> I haven't tested your patch, but I'm asking myself whether it cooperates
>> with autorevert triggered by file notifications.
>> ...
>> Have you tested this scenario?
>
> YES! In fact, that was a major motivation for the submission, and
> the primary method of testing it.
>
> Please do test the patch, and report back.
I see (still haven't tested, just reviewing). I don't understand yet,
why it is necessary to move "(setq auto-revert-notify-modified-p nil)"
into the "(when (and revert ..." form.
Furthermore, I see a problem to call auto-revert functionality in
files.el. autorevert.el is not dumped into the emacs binary. Wouldn't it
be better to add a function to find-file-hook? I understand the problem
with adding a newline at file end, but maybe this could be solved differently?
Best regards, Michael.
next prev parent reply other threads:[~2020-09-17 11:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 4:07 bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Boruch Baum
2020-09-15 14:30 ` Eli Zaretskii
2020-09-15 15:39 ` Boruch Baum
2020-09-15 15:49 ` Eli Zaretskii
2020-09-15 16:12 ` Boruch Baum
2020-09-15 17:24 ` Eli Zaretskii
2020-09-16 20:11 ` Boruch Baum
2020-09-17 13:13 ` Eli Zaretskii
2020-09-17 20:10 ` Boruch Baum
2020-09-18 6:35 ` Eli Zaretskii
2020-09-18 7:49 ` martin rudalics
2020-09-29 13:05 ` Boruch Baum
2020-09-29 14:34 ` martin rudalics
2020-09-29 14:45 ` Eli Zaretskii
2020-09-15 18:47 ` Michael Albinus
2020-09-15 19:31 ` Boruch Baum
2020-09-17 11:07 ` Michael Albinus [this message]
2020-09-17 20:03 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2l8slux.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=43412@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).