From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Date: Thu, 17 Sep 2020 13:07:02 +0200 Message-ID: <87y2l8slux.fsf@gmx.de> References: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> <87o8m6ri6u.fsf@gmx.de> <20200915193146.rcrylluhr7ah7dst@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43412@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 13:08:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIrm5-000261-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 13:08:25 +0200 Original-Received: from localhost ([::1]:35146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIrm4-0001tx-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 07:08:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIrli-0001tp-9D for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 07:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIrli-0002BS-0A for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 07:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIrlh-0007lW-Po for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 07:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43412-submit@debbugs.gnu.org id=B43412.160034083529786 (code B ref 43412); Thu, 17 Sep 2020 11:08:01 +0000 Original-Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 11:07:15 +0000 Original-Received: from localhost ([127.0.0.1]:37396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIrkx-0007kM-05 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 07:07:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:48189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIrks-0007k7-67 for 43412@debbugs.gnu.org; Thu, 17 Sep 2020 07:07:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600340824; bh=+WQjBWqnnz3h4X0Iao6CZc1dvuKm+advAgC1g5dqmOg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=FGd7txDP+oAUVbKS1uYAo1mXsTXL87+hnE87MtgTWzel1SdiMJTdJ+JJMC0zQ27oA qE0E1Q5uuTSE3f0ujrq93JRdSZpqss3683YCPY9BANo+t8VUqOvUyXSJ4IXovWghq+ UQJB1U33blFqHQRes1vqYB/OmoirXfzfrCvbuBlY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.37.67]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8obG-1kWjoH3KJa-015uUW; Thu, 17 Sep 2020 13:07:03 +0200 In-Reply-To: <20200915193146.rcrylluhr7ah7dst@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 15 Sep 2020 15:31:47 -0400") X-Provags-ID: V03:K1:PVBneNqTFjzd6ceO++Qp2UROpU0tpuFjVYoIaywWTFegs6ChrgQ xdAjBNhvSOqwGEfc7op3o/YexFdw/+EXvoZYzWVt3zkMmgLqNDKn22bBRzcnm97Hr6AA2s0 hsfKXjzUlyevj2AO7c34oWbXq+lg8Vpjt6/U82Y2uqTNJtIfxYqzEaGFg/JCHq0WvE1tmv2 aSqcrqWbPuFiQrZJfLhgg== X-UI-Out-Filterresults: notjunk:1;V03:K0:GWiw02y5MS0=:pGnx21KYtPSZAk3s3qzotm FL1jL6zW34HKQOeSPock3juHtWeRNlDcC4Ai80pAHMkHs019XUAV2xmR0vg/IQ4nCBxVXunru CA05qe/QxqJMCAJV5KNUzXHX9KAwwZKXO61PHpFEUDENjcvTb0wHnn3xWhpQbCsDPSFU2IkD6 bxmpBedZZM5NWXFmLiJM2XNxfQOXzHEPHmqn/4UHMarlkwUq+I0bUEEUjPvLCC//b9i4qoMXo AoQ+EfmoH9iwvfuHZIFwgIxXxTzlch/pHWmuR7fuH1RFN6VlSm3WjiSC1M00YW5Rtg4S85VU8 ERspSr4wOzM5h2ftWSDjgCplox6EES2CZZa28EyL24xjBFcIDVHeXancdg07n+vlHHDmA5++5 hL+3VUl6Rc6wxnsbL4AqJPGHkO441hqAXC5R9Ucj6Dd+Ss6bJd4Aq5vMTlYsjNSHroH8dUj1B 8Vyy3wpzHMsXv1C8kYS+dbo7Ux84W3iY/3yFtkKOS42Wh2Ot0kqj5/MtKSkxbqNmrew8HFJ6H wHSteRaOtA65aqJeOZEhbcYMfDRVZpSGAbILtjnpnJv5sUhPNU5BPcvMQcYN4UvpFIyZLYmfN CS+BDabzxbhrDMYD5XJV2bId9G2IjcB2d0/lCScjeVjDSxET1YcNK3pHF/S/gLRoM2kR8xpwo zSs6tLOSeBXyAMXrDEbGwpzM/JA4K03U1miceCpLFD0q6pMOQ9GBF+t9te2Qw9uCEbak05Ijj prEa/vMFAYZi/037QXU+0bm7+PnB65BdPJgKx6EB8gC5i9/ABrzDs2bYeklAmlcws6dpozkz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188193 Archived-At: Boruch Baum writes: Hi Boruch, >> I haven't tested your patch, but I'm asking myself whether it cooperates >> with autorevert triggered by file notifications. >> ... >> Have you tested this scenario? > > YES! In fact, that was a major motivation for the submission, and > the primary method of testing it. > > Please do test the patch, and report back. I see (still haven't tested, just reviewing). I don't understand yet, why it is necessary to move "(setq auto-revert-notify-modified-p nil)" into the "(when (and revert ..." form. Furthermore, I see a problem to call auto-revert functionality in files.el. autorevert.el is not dumped into the emacs binary. Wouldn't it be better to add a function to find-file-hook? I understand the problem with adding a newline at file end, but maybe this could be solved differently? Best regards, Michael.