From: Matthias Meulien <orontee@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 57821@debbugs.gnu.org
Subject: bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer
Date: Mon, 19 Sep 2022 20:12:32 +0200 [thread overview]
Message-ID: <87y1ufgrn3.fsf@gmail.com> (raw)
In-Reply-To: <87zgevwzfh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 10:17:38 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Matthias Meulien <orontee@gmail.com> writes:
>
>> Here is a patch improving the news entry and fixing the defalias for
>> variables you mentionned in your other message.
>
> I see that Eli has rewritten parts of the documentation here... Can you
> have a read of the current trunk and see whether there's anything more
> to do here?
Here are the fixes left after Eli's work. To my knowledge the only
known problem still to address is the renaming of the button type
comint-osc-hyperlink to osc-hyperlink; I've not found time to study
Basil advice.
diff --git a/etc/NEWS b/etc/NEWS
index 723bdd7c75..ee333a84e4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2450,7 +2450,9 @@ Adding the new function 'osc-compilation-filter' to
sequences in compilation buffers. By default, all sequences are
filtered out.
-A handler for OSC 2, the command to set a window title, is provided.
+The list of handlers (already covering OSC 7 and 8) has been extended
+with a handler for OSC 2, the command to set a window title.
+
+++
*** New user option 'project-vc-include-untracked'.
diff --git a/lisp/comint.el b/lisp/comint.el
index afaa27c2c0..b2a04ea55a 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -3916,11 +3916,11 @@ comint-redirect-results-list-from-process
;; sequences.
;; Aliases defined for reverse compatibility
-(defalias 'comint-osc-handlers 'osc-handlers)
+(defvaralias 'comint-osc-handlers 'osc-handlers)
(defalias 'comint-osc-directory-tracker 'osc-directory-tracker)
(defalias 'comint-osc-hyperlink-handler 'osc-hyperlink-handler)
(defalias 'comint-osc-hyperlink 'osc-hyperlink)
-(defalias 'comint-osc-hyperlink-map 'osc-hyperlink-map)
+(defvaralias 'comint-osc-hyperlink-map 'osc-hyperlink-map)
(defun comint-osc-process-output (_)
"Interpret OSC escape sequences in comint output.
diff --git a/lisp/osc.el b/lisp/osc.el
index 8f4cd630ba..14f7fe6a4f 100644
--- a/lisp/osc.el
+++ b/lisp/osc.el
@@ -22,14 +22,14 @@
;;; Commentary:
-;; Interpretation of OSC (Operating System Commands) escape
-;; sequences. Handlers for OSC 2, 7 and 8 (for window title, current
-;; directory and hyperlinks respectively) are provided.
+;; Interpretation of OSC (Operating System Commands) escape sequences.
+;; Handlers for OSC 2, 7 and 8 (for window title, current directory
+;; and hyperlinks respectively) are provided.
;; The function `osc-compilation-filter' can be added to
;; `compilation-filter-hook' to collect OSC sequences in compilation
-;; buffers. The variable `osc-for-compilation-buffer' tells what to do
-;; with collected sequences.
+;; buffers. The variable `osc-for-compilation-buffer' tells what to
+;; do with collected sequences.
;;; Code:
--
Matthias
next prev parent reply other threads:[~2022-09-19 18:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 8:24 bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer Matthias Meulien
2022-09-15 11:13 ` Matthias Meulien
2022-09-16 11:20 ` Lars Ingebrigtsen
2022-09-16 20:59 ` Matthias Meulien
2022-09-17 17:21 ` Matthias Meulien
2022-09-18 10:33 ` Lars Ingebrigtsen
2022-09-18 12:45 ` Matthias Meulien
2022-09-18 12:52 ` Lars Ingebrigtsen
2022-09-18 13:42 ` Matthias Meulien
2022-09-18 13:46 ` Lars Ingebrigtsen
2022-09-18 15:19 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-18 15:45 ` Matthias Meulien
2022-09-18 16:27 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-19 8:17 ` Lars Ingebrigtsen
2022-09-19 8:38 ` Matthias Meulien
2022-09-19 18:12 ` Matthias Meulien [this message]
2022-09-19 18:47 ` Lars Ingebrigtsen
2022-09-18 19:03 ` Jose A Ortega Ruiz
2022-09-18 19:11 ` Eli Zaretskii
2022-09-18 20:56 ` Matthias Meulien
2022-09-18 15:19 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1ufgrn3.fsf@gmail.com \
--to=orontee@gmail.com \
--cc=57821@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).