From: Matthias Meulien <orontee@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 57821@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer
Date: Sun, 18 Sep 2022 17:45:45 +0200 [thread overview]
Message-ID: <87tu543cuu.fsf@gmail.com> (raw)
In-Reply-To: <87fsgopv5j.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 18 Sep 2022 18:19:36 +0300")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Matthias Meulien [2022-09-18 15:42 +0200] wrote:
>
>> +*** New package 'osc'.
>> +Support for OSC ("Operating System Command") espace sequences has been
>> +extracted from 'comint.el' in order to provide interpretation of OSC
>> +escape sequences in compilation buffers.
>> +
>> +Adding the new function 'osc-compilation-filter' to
>> +'compilation-filter-hook' enables interpretation of OSC ("Operating
>> +System Command") escape sequences in compilation buffers. By default,
> ^^
> Two spaces after a full stop, here and in the other patches.
Thanks for your careful reading! I failed to found places with this
problem in the other patches...
>> +all sequences are filtered out.
>> +
>> +A handler for OSC 2, the command to set a window title, is provided.
>
> Also OSC 7 and 8, no?
Sure, I thought it's a new handler was implicit in the NEWS file; Other
handlers were already mentionned in NEWS.28. But let's try to be more
precise.
>
> BTW, the commentary in comint.el doesn't mention OSC 2.
+1
Here is a patch improving the news entry and fixing the defalias for
variables you mentionned in your other message. I didn't tried to solve
the alias for the button; I'll have to learn more about aliases first, I
thought that just "maintaining" the symbol would be ok.
diff --git a/etc/NEWS b/etc/NEWS
index 88d00d9474..5fe96b0e0c 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2441,11 +2441,12 @@ extracted from 'comint.el' in order to provide interpretation of OSC
escape sequences in compilation buffers.
Adding the new function 'osc-compilation-filter' to
-'compilation-filter-hook' enables interpretation of OSC ("Operating
-System Command") escape sequences in compilation buffers. By default,
-all sequences are filtered out.
+'compilation-filter-hook' enables interpretation of OSC escape
+sequences in compilation buffers. By default, all sequences are
+filtered out.
-A handler for OSC 2, the command to set a window title, is provided.
+The list of handlers (covering OSC 7 and 8) has been extended with a
+handler for OSC 2, the command to set a window title.
+++
*** New user option 'project-vc-include-untracked'.
diff --git a/lisp/comint.el b/lisp/comint.el
index afaa27c2c0..202cf6eab5 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -3910,17 +3910,17 @@ comint-redirect-results-list-from-process
;;============================================================================
;; Adding `comint-osc-process-output' to
;; `comint-output-filter-functions' enables the interpretation of OSC
-;; escape sequences. By default, OSC 7 and 8 (for current directory
-;; and hyperlinks respectively) are acted upon. Adding more entries
-;; to `comint-osc-handlers' allows a customized treatment of further
-;; sequences.
+;; escape sequences. By default, OSC 2, 7 and 8 (for window title,
+;; current directory and hyperlinks respectively) are acted upon.
+;; Adding more entries to `comint-osc-handlers' allows a customized
+;; treatment of further sequences.
;; Aliases defined for reverse compatibility
-(defalias 'comint-osc-handlers 'osc-handlers)
+(defvaralias 'comint-osc-handlers 'osc-handlers)
(defalias 'comint-osc-directory-tracker 'osc-directory-tracker)
(defalias 'comint-osc-hyperlink-handler 'osc-hyperlink-handler)
(defalias 'comint-osc-hyperlink 'osc-hyperlink)
-(defalias 'comint-osc-hyperlink-map 'osc-hyperlink-map)
+(defvaralias 'comint-osc-hyperlink-map 'osc-hyperlink-map)
(defun comint-osc-process-output (_)
"Interpret OSC escape sequences in comint output.
next prev parent reply other threads:[~2022-09-18 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 8:24 bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer Matthias Meulien
2022-09-15 11:13 ` Matthias Meulien
2022-09-16 11:20 ` Lars Ingebrigtsen
2022-09-16 20:59 ` Matthias Meulien
2022-09-17 17:21 ` Matthias Meulien
2022-09-18 10:33 ` Lars Ingebrigtsen
2022-09-18 12:45 ` Matthias Meulien
2022-09-18 12:52 ` Lars Ingebrigtsen
2022-09-18 13:42 ` Matthias Meulien
2022-09-18 13:46 ` Lars Ingebrigtsen
2022-09-18 15:19 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-18 15:45 ` Matthias Meulien [this message]
2022-09-18 16:27 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-19 8:17 ` Lars Ingebrigtsen
2022-09-19 8:38 ` Matthias Meulien
2022-09-19 18:12 ` Matthias Meulien
2022-09-19 18:47 ` Lars Ingebrigtsen
2022-09-18 19:03 ` Jose A Ortega Ruiz
2022-09-18 19:11 ` Eli Zaretskii
2022-09-18 20:56 ` Matthias Meulien
2022-09-18 15:19 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu543cuu.fsf@gmail.com \
--to=orontee@gmail.com \
--cc=57821@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).