From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer Date: Mon, 19 Sep 2022 20:12:32 +0200 Message-ID: <87y1ufgrn3.fsf@gmail.com> References: <87fsgt11w0.fsf@gmail.com> <87bkrg28lu.fsf@gmail.com> <877d23a7mh.fsf@gnus.org> <87tu55zzll.fsf@gmail.com> <87mtax55v7.fsf@gnus.org> <8735co4zse.fsf@gmail.com> <87k06026bw.fsf@gnus.org> <87y1ug3ik4.fsf@gmail.com> <87fsgopv5j.fsf@tcd.ie> <87tu543cuu.fsf@gmail.com> <87zgevwzfh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8292"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 57821@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 20:34:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaLbb-0001vg-El for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 20:34:55 +0200 Original-Received: from localhost ([::1]:56148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaLba-0004rm-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 14:34:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaLGR-0000Hg-8a for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 14:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaLGQ-0000Xe-Um for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 14:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaLGQ-0004Jh-G4 for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57821 X-GNU-PR-Package: emacs Original-Received: via spool by 57821-submit@debbugs.gnu.org id=B57821.166361116516567 (code B ref 57821); Mon, 19 Sep 2022 18:13:02 +0000 Original-Received: (at 57821) by debbugs.gnu.org; 19 Sep 2022 18:12:45 +0000 Original-Received: from localhost ([127.0.0.1]:55162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLG8-0004J9-Os for submit@debbugs.gnu.org; Mon, 19 Sep 2022 14:12:45 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:35632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLG7-0004Iv-1P for 57821@debbugs.gnu.org; Mon, 19 Sep 2022 14:12:43 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id r7so443942wrm.2 for <57821@debbugs.gnu.org>; Mon, 19 Sep 2022 11:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=UGSEJMpepep+jKnrDPzX5bQw4i/dCKXT0mGcclqv/Ic=; b=KRyrZ/dn7R7QeXBeIZjYPvwePDd0kqtuYt/17nAXWkvDSO/jAT2+vdppk+RNvcjb2E dpy3cehv2wSiZHoppHQwtp/N7IQbO5vEIJ06rr5cO3KN5F7JSChtHCuLYVj9iDtXHxkX bqg9P77jqh1WA2HoXviI+uXB4Yf3PAmnr0jebRbWqxBTclMFS4XgUlCRTjqz4q32QaQy 8PPlqmHJBq6qEoYMxgdhPzFy3BP32tH9RkfohrnAQV3qP4i6IdsO8C2P4ir9M4Pd9KKB mUyN9YEeRXtcAhHHJQDMI2GT5fu2hoCdQnfqwdHTZQLp4725jie5uIxEfSGo0sfuyslc MTbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=UGSEJMpepep+jKnrDPzX5bQw4i/dCKXT0mGcclqv/Ic=; b=j57xu2w5tbK9/cdJ2xiMDKyig8E0izcz+cK8hslsmW/IC3/KrLtdKeSRBLCX1107Ui vWGlv4VgRRgoJ1PWFm4ugNFr89B0b9W+p5DDW5XzCs23MDtxJe2uLvLEKQs2D19Uo32q VHg6/ANTXAoiRLGp3UPrnkRnPjbrGDogHZ1ipj7WOl4jk5AHRYnr7IzYcRlskbFk8LKV 4jVsLwrSRaN06Z0uF6bIKOTYbGh7VnQg2ho3iKDa4wxwysS4mL5wybkNrWtY9kYIZUrE OL6HW0/g8FnnbKo89Wns1keqXIBuGx+87Itf042rgdkRhZHoIM5fOrA8IeQPWcVzhLQ5 f7Aw== X-Gm-Message-State: ACrzQf1L+GoEQe0dQKHPhBD71p37dl4GJ0X0iJk4/BQ/52dR/O/rBEtV t5QXcWDLMx2X4NP1KUb+vgu4eTbE2Hc= X-Google-Smtp-Source: AMsMyM5LMwSqjJ1jmt5BliJzCj101K2d6PrCAyXejsrgMbHx/H6MGTNcfAS53UGhWhsCRVjyHmX6CA== X-Received: by 2002:a05:6000:1687:b0:22a:3516:4f98 with SMTP id y7-20020a056000168700b0022a35164f98mr11482123wrd.525.1663611157066; Mon, 19 Sep 2022 11:12:37 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id h130-20020a1c2188000000b003a682354f63sm14992976wmh.11.2022.09.19.11.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 11:12:36 -0700 (PDT) In-Reply-To: <87zgevwzfh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 10:17:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243110 Archived-At: Lars Ingebrigtsen writes: > Matthias Meulien writes: > >> Here is a patch improving the news entry and fixing the defalias for >> variables you mentionned in your other message. > > I see that Eli has rewritten parts of the documentation here... Can you > have a read of the current trunk and see whether there's anything more > to do here? Here are the fixes left after Eli's work. To my knowledge the only known problem still to address is the renaming of the button type comint-osc-hyperlink to osc-hyperlink; I've not found time to study Basil advice. diff --git a/etc/NEWS b/etc/NEWS index 723bdd7c75..ee333a84e4 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -2450,7 +2450,9 @@ Adding the new function 'osc-compilation-filter' to sequences in compilation buffers. By default, all sequences are filtered out. -A handler for OSC 2, the command to set a window title, is provided. +The list of handlers (already covering OSC 7 and 8) has been extended +with a handler for OSC 2, the command to set a window title. + +++ *** New user option 'project-vc-include-untracked'. diff --git a/lisp/comint.el b/lisp/comint.el index afaa27c2c0..b2a04ea55a 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -3916,11 +3916,11 @@ comint-redirect-results-list-from-process ;; sequences. ;; Aliases defined for reverse compatibility -(defalias 'comint-osc-handlers 'osc-handlers) +(defvaralias 'comint-osc-handlers 'osc-handlers) (defalias 'comint-osc-directory-tracker 'osc-directory-tracker) (defalias 'comint-osc-hyperlink-handler 'osc-hyperlink-handler) (defalias 'comint-osc-hyperlink 'osc-hyperlink) -(defalias 'comint-osc-hyperlink-map 'osc-hyperlink-map) +(defvaralias 'comint-osc-hyperlink-map 'osc-hyperlink-map) (defun comint-osc-process-output (_) "Interpret OSC escape sequences in comint output. diff --git a/lisp/osc.el b/lisp/osc.el index 8f4cd630ba..14f7fe6a4f 100644 --- a/lisp/osc.el +++ b/lisp/osc.el @@ -22,14 +22,14 @@ ;;; Commentary: -;; Interpretation of OSC (Operating System Commands) escape -;; sequences. Handlers for OSC 2, 7 and 8 (for window title, current -;; directory and hyperlinks respectively) are provided. +;; Interpretation of OSC (Operating System Commands) escape sequences. +;; Handlers for OSC 2, 7 and 8 (for window title, current directory +;; and hyperlinks respectively) are provided. ;; The function `osc-compilation-filter' can be added to ;; `compilation-filter-hook' to collect OSC sequences in compilation -;; buffers. The variable `osc-for-compilation-buffer' tells what to do -;; with collected sequences. +;; buffers. The variable `osc-for-compilation-buffer' tells what to +;; do with collected sequences. ;;; Code: -- Matthias