From: Stephen Berman <stephen.berman@gmx.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 17388@debbugs.gnu.org
Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing
Date: Fri, 02 May 2014 20:57:58 +0200 [thread overview]
Message-ID: <87wqe43t55.fsf@rosalinde.fritz.box> (raw)
In-Reply-To: <eb90ee40-d0cb-46f0-8ce1-1759d110cbbd@default> (Drew Adams's message of "Fri, 2 May 2014 08:15:09 -0700 (PDT)")
On Fri, 2 May 2014 08:15:09 -0700 (PDT) Drew Adams <drew.adams@oracle.com> wrote:
> 1. A diff that is not the current one should use face
> `ediff-(odd|even)-diff-(A|B'). This is now broken.
>
> It does use that face for the main diff, but it still tries to show fine
> differences within that diff - which is new. That would be OK, I guess,
> but it should not use face `default' to show such fine diffs. It should
> use an Ediff face, which users can customize without affecting other
> things (as happens with `default').
>
> Using face `default' here is particular misguided, as it suggests that
> there is no difference at those locations, whereas there likely is.
>
> See the attached screenshot. The first diff shown, with the gray
> highlighting, shows the regression.
>
>
> 2. The fine diffs are also not correct. See the same screenshot. For
> the first diff, "advertise" and "d-signature-table" should be
> highlighted the same as "(defvar " and ")", and for the second diff,
> "fil" and "s-alist" should be highlighted the same as "(defvar " and
> ")". These are not differences.
>
> I am using Cygwin `diff', which could affect #2 presumably. But #2 is
> still a regression wrt prior Emacs versions. With Emacs 24.3, for
> instance (using the same Cygwin `diff'), there is no fine diff shown
> here. Instead, the diff, which is shown only as a main diff, is between
> "file-local-variables-alist" and "filxxxxxxxxxxxxxxxxxxxxxs-alist".
> Which is correct.
>
> Emacs should not show fine diffs that are are patently wrong.
> Better not to mislead.
>
>
>
> In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
> of 2014-04-29 on ODIEONE
> Bzr revision: 117031 monnier@iro.umontreal.ca-20140429151607-qnkgbymwfaj5ut08
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
> `configure --prefix=/c/Devel/emacs/snapshot/trunk
> --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
> LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
> -Ic:/Devel/emacs/include''
I see both of these problematic highlightings on GNU/Linux builds from
both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049).
Steve Berman
next prev parent reply other threads:[~2014-05-02 18:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 15:15 bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Drew Adams
2014-05-02 18:57 ` Stephen Berman [this message]
2014-05-03 2:27 ` Stefan Monnier
2014-05-03 3:11 ` Drew Adams
2014-05-03 6:48 ` Eli Zaretskii
[not found] <<eb90ee40-d0cb-46f0-8ce1-1759d110cbbd@default>
[not found] ` <<87wqe43t55.fsf@rosalinde.fritz.box>
[not found] ` <<jwvwqe3mx1m.fsf-monnier+emacsbugs@gnu.org>
[not found] ` <<111c9271-6a23-426e-adb2-ff5520c02806@default>
[not found] ` <<83a9az1hok.fsf@gnu.org>
2014-05-03 14:01 ` Drew Adams
2014-05-03 16:42 ` Eli Zaretskii
[not found] ` <8613042fc3be4f9995e33e38d4f079f0@HUBCAS1.cs.stonybrook.edu>
2014-05-03 15:57 ` Michael Kifer
2014-05-03 20:41 ` Drew Adams
2014-05-04 3:54 ` Stefan Monnier
2014-05-04 7:16 ` Drew Adams
[not found] ` <<bbf71aaa-f669-4542-a8d1-b7ff9d40d66e@default>
[not found] ` <<83y4yizue3.fsf@gnu.org>
2014-05-03 20:56 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqe43t55.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=17388@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).