unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 17388@debbugs.gnu.org, kifer@cs.stonybrook.edu
Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing
Date: Sat, 3 May 2014 07:01:13 -0700 (PDT)	[thread overview]
Message-ID: <bbf71aaa-f669-4542-a8d1-b7ff9d40d66e@default> (raw)
In-Reply-To: <<83a9az1hok.fsf@gnu.org>>

> > There should be EITHER, (a) as previously, NO fine diffs shown for
> > other than the current diff OR (b) CORRECT (helpful) fine diffs
> > shown for the non-current diffs.
> 
> Ediff's "fine diffs" are word-granular.  That is, Ediff breaks each
> line into "words", then passes the result to the Diff program for
> comparisoon, and reflects the results with different faces.  AFAIR,
> this has always been that way.

OK, so you are saying that Emacs has silently changed to (b) from (a),
and the way it does fine diffs corresponds to what is shown.  So be it.

> > > I see both of these problematic highlightings on GNU/Linux builds from
> > > both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049).
> 
> I can confirm that too, but (a) I don't think the 2nd issue
> constitutes a "problem" (see above), and (b) it is definitely not a
> "REGRESSION", because older Emacsen behaved the same wrt fine diffs
> inside a line.

It is a change in behavior wrt older Emacsen, which do not show fine
diffs within the non-current diffs.  Regression or improvement - we
can have different opinions.  (BTW, I see nothing in NEWS about this
behavior change.)

But more importantly, "REGRESSION" in the subject line is for the bug
report, and #1 is the more serious part: removing diff highlighting
from part of a diff gives the impression that that unhighlighted text
is not different.





       reply	other threads:[~2014-05-03 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<eb90ee40-d0cb-46f0-8ce1-1759d110cbbd@default>
     [not found] ` <<87wqe43t55.fsf@rosalinde.fritz.box>
     [not found]   ` <<jwvwqe3mx1m.fsf-monnier+emacsbugs@gnu.org>
     [not found]     ` <<111c9271-6a23-426e-adb2-ff5520c02806@default>
     [not found]       ` <<83a9az1hok.fsf@gnu.org>
2014-05-03 14:01         ` Drew Adams [this message]
2014-05-03 16:42           ` bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Eli Zaretskii
     [not found]         ` <8613042fc3be4f9995e33e38d4f079f0@HUBCAS1.cs.stonybrook.edu>
2014-05-03 15:57           ` Michael Kifer
2014-05-03 20:41             ` Drew Adams
2014-05-04  3:54               ` Stefan Monnier
2014-05-04  7:16                 ` Drew Adams
     [not found]         ` <<bbf71aaa-f669-4542-a8d1-b7ff9d40d66e@default>
     [not found]           ` <<83y4yizue3.fsf@gnu.org>
2014-05-03 20:56             ` Drew Adams
2014-05-02 15:15 Drew Adams
2014-05-02 18:57 ` Stephen Berman
2014-05-03  2:27   ` Stefan Monnier
2014-05-03  3:11     ` Drew Adams
2014-05-03  6:48       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbf71aaa-f669-4542-a8d1-b7ff9d40d66e@default \
    --to=drew.adams@oracle.com \
    --cc=17388@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kifer@cs.stonybrook.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).