From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#17388: 24.4.50; REGRESSION: Ediff - 1) wrong face, 2) incorrect diffing Date: Fri, 02 May 2014 20:57:58 +0200 Message-ID: <87wqe43t55.fsf@rosalinde.fritz.box> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399057165 16514 80.91.229.3 (2 May 2014 18:59:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 May 2014 18:59:25 +0000 (UTC) Cc: 17388@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 02 20:59:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgIg1-000274-D6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 May 2014 20:59:17 +0200 Original-Received: from localhost ([::1]:45869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgIg0-00062t-U3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 May 2014 14:59:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgIfs-00062l-HN for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 14:59:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgIfm-0002PK-UL for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 14:59:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgIfm-0002P9-Py for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 14:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgIfl-0005bd-Vz for bug-gnu-emacs@gnu.org; Fri, 02 May 2014 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 May 2014 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17388-submit@debbugs.gnu.org id=B17388.139905711421508 (code B ref 17388); Fri, 02 May 2014 18:59:01 +0000 Original-Received: (at 17388) by debbugs.gnu.org; 2 May 2014 18:58:34 +0000 Original-Received: from localhost ([127.0.0.1]:48695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgIfJ-0005aq-MK for submit@debbugs.gnu.org; Fri, 02 May 2014 14:58:33 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:57550) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgIfH-0005ac-CF for 17388@debbugs.gnu.org; Fri, 02 May 2014 14:58:32 -0400 Original-Received: from rosalinde.fritz.box ([89.245.97.102]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LvPgd-1Wo23R36vL-010cC3; Fri, 02 May 2014 20:58:22 +0200 In-Reply-To: (Drew Adams's message of "Fri, 2 May 2014 08:15:09 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) X-Provags-ID: V03:K0:APAJyzUrZnFwlfjccxq9BTE5no00iTZj1XxZAY9XNvmg+OIQyNE ctg0Nd2oz71Z8pugX26CmS3NbC2Z84aKbDF/m6mRPiuPWG7vq9RfOan+bmTw19C33q65/nK 87h+I85daes4l02rNjXD6RHkafeyIyppFYXTF3FuDoC9SpfwE1Ffd+4P5zigD1YooOIs9pj 8VfVA/RuZzZBFV2mxeRLw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88538 Archived-At: On Fri, 2 May 2014 08:15:09 -0700 (PDT) Drew Adams wrote: > 1. A diff that is not the current one should use face > `ediff-(odd|even)-diff-(A|B'). This is now broken. > > It does use that face for the main diff, but it still tries to show fine > differences within that diff - which is new. That would be OK, I guess, > but it should not use face `default' to show such fine diffs. It should > use an Ediff face, which users can customize without affecting other > things (as happens with `default'). > > Using face `default' here is particular misguided, as it suggests that > there is no difference at those locations, whereas there likely is. > > See the attached screenshot. The first diff shown, with the gray > highlighting, shows the regression. > > > 2. The fine diffs are also not correct. See the same screenshot. For > the first diff, "advertise" and "d-signature-table" should be > highlighted the same as "(defvar " and ")", and for the second diff, > "fil" and "s-alist" should be highlighted the same as "(defvar " and > ")". These are not differences. > > I am using Cygwin `diff', which could affect #2 presumably. But #2 is > still a regression wrt prior Emacs versions. With Emacs 24.3, for > instance (using the same Cygwin `diff'), there is no fine diff shown > here. Instead, the diff, which is shown only as a main diff, is between > "file-local-variables-alist" and "filxxxxxxxxxxxxxxxxxxxxxs-alist". > Which is correct. > > Emacs should not show fine diffs that are are patently wrong. > Better not to mislead. > > > > In GNU Emacs 24.4.50.1 (i686-pc-mingw32) > of 2014-04-29 on ODIEONE > Bzr revision: 117031 monnier@iro.umontreal.ca-20140429151607-qnkgbymwfaj5ut08 > Windowing system distributor `Microsoft Corp.', version 6.1.7601 > Configured using: > `configure --prefix=/c/Devel/emacs/snapshot/trunk > --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' > LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1 > -Ic:/Devel/emacs/include'' I see both of these problematic highlightings on GNU/Linux builds from both the trunk (bzr 117042) and the emacs-24 branch (bzr 117049). Steve Berman