bug#36540: [PATCH] Small cleanups in asm-mode.el

bug#36540: [PATCH] Small cleanups in asm-mode.el

[Stefan Kangas]

Just some small cleanups in asm-mode.el.

(I'll send the patch in a separate message once this is
assigned a bug number.)

Thanks,
Stefan Kangas

bug#36540: [PATCH] Small cleanups in asm-mode.el

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 16 bytes --]

Patch attached.

[-- Attachment #2: 0001-Small-cleanups-in-asm-mode.el-Bug-36540.patch --]
[-- Type: text/x-patch, Size: 2189 bytes --]

From 9f10f4d25c72f13859cc55fbe938f46cb35cc57e Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 7 Jul 2019 16:27:26 +0200
Subject: [PATCH] Small cleanups in asm-mode.el (Bug#36540)

* lisp/progmodes/asm-mode.el: Remove "tools" from "Keywords" header.
Doc fixes.
(asm-comment-char, asm-comment): Doc fixes.
(asm-newline): Redefine as an obsolete function alias for
'newline-and-indent' instead of using a defalias.
---
 lisp/progmodes/asm-mode.el | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lisp/progmodes/asm-mode.el b/lisp/progmodes/asm-mode.el
index c56d16e305..5390ef7cd2 100644
--- a/lisp/progmodes/asm-mode.el
+++ b/lisp/progmodes/asm-mode.el
@@ -4,7 +4,7 @@
 
 ;; Author: Eric S. Raymond <esr@snark.thyrsus.com>
 ;; Maintainer: emacs-devel@gnu.org
-;; Keywords: tools, languages
+;; Keywords: languages
 
 ;; This file is part of GNU Emacs.
 
@@ -26,7 +26,7 @@
 ;; This mode was written by Eric S. Raymond <esr@snark.thyrsus.com>,
 ;; inspired by an earlier asm-mode by Martin Neitzel.
 
-;; This minor mode is based on text mode.  It defines a private abbrev table
+;; This major mode is based on prog mode.  It defines a private abbrev table
 ;; that can be used to save abbrevs for assembler mnemonics.  It binds just
 ;; five keys:
 ;;
@@ -53,7 +53,7 @@ asm
   :group 'languages)
 
 (defcustom asm-comment-char ?\;
-  "The comment-start character assumed by Asm mode."
+  "The `comment-start' character assumed by Asm mode."
   :type 'character
   :group 'asm)
 
@@ -187,14 +187,13 @@ asm-colon
       (delete-horizontal-space)
       (tab-to-tab-stop))))
 
-;; Obsolete since Emacs-22.1.
-(defalias 'asm-newline 'newline-and-indent)
+(define-obsolete-function-alias 'asm-newline 'newline-and-indent "27.1")
 
 (defun asm-comment ()
   "Convert an empty comment to a `larger' kind, or start a new one.
 These are the known comment classes:
 
-   1 -- comment to the right of the code (at the comment-column)
+   1 -- comment to the right of the code (at the `comment-column')
    2 -- comment on its own line, indented like code
    3 -- comment on its own line, beginning at the left-most column.
 
-- 
2.11.0

bug#36540: [PATCH] Small cleanups in asm-mode.el

[Basil L. Contovounesios]

tags 36540 fixed
close 36540 27.1
quit

Stefan Kangas <stefan@marxist.se> writes:

> Patch attached.

Pushed to master[1], followed by an update to the docstring of
asm-mode[2] to not mention asm-newline.

[1]: Small cleanups in asm-mode.el (Bug#36540)
ddc8c2c298 2019-07-10 14:54:39 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ddc8c2c298d99bc084523786e5deac5ea2e6ee84

[2]: ; Update asm-mode docstring after last change
ff5dd4ed76 2019-07-10 14:58:32 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ff5dd4ed76c9854ad8a566cea8ddcdf5c8ffabd6

Thanks,

-- 
Basil