unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: 36540@debbugs.gnu.org
Subject: bug#36540: [PATCH] Small cleanups in asm-mode.el
Date: Sun, 7 Jul 2019 16:47:43 +0200	[thread overview]
Message-ID: <CADwFkmk7E44tZstxU7KEp0eArK7hjh+fExKLQjsGibA7964nbA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmzcxsyF8hHhB73-EugVgAMNPwu7sKR0vYa_oSz8qXKEA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 16 bytes --]

Patch attached.

[-- Attachment #2: 0001-Small-cleanups-in-asm-mode.el-Bug-36540.patch --]
[-- Type: text/x-patch, Size: 2189 bytes --]

From 9f10f4d25c72f13859cc55fbe938f46cb35cc57e Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 7 Jul 2019 16:27:26 +0200
Subject: [PATCH] Small cleanups in asm-mode.el (Bug#36540)

* lisp/progmodes/asm-mode.el: Remove "tools" from "Keywords" header.
Doc fixes.
(asm-comment-char, asm-comment): Doc fixes.
(asm-newline): Redefine as an obsolete function alias for
'newline-and-indent' instead of using a defalias.
---
 lisp/progmodes/asm-mode.el | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lisp/progmodes/asm-mode.el b/lisp/progmodes/asm-mode.el
index c56d16e305..5390ef7cd2 100644
--- a/lisp/progmodes/asm-mode.el
+++ b/lisp/progmodes/asm-mode.el
@@ -4,7 +4,7 @@
 
 ;; Author: Eric S. Raymond <esr@snark.thyrsus.com>
 ;; Maintainer: emacs-devel@gnu.org
-;; Keywords: tools, languages
+;; Keywords: languages
 
 ;; This file is part of GNU Emacs.
 
@@ -26,7 +26,7 @@
 ;; This mode was written by Eric S. Raymond <esr@snark.thyrsus.com>,
 ;; inspired by an earlier asm-mode by Martin Neitzel.
 
-;; This minor mode is based on text mode.  It defines a private abbrev table
+;; This major mode is based on prog mode.  It defines a private abbrev table
 ;; that can be used to save abbrevs for assembler mnemonics.  It binds just
 ;; five keys:
 ;;
@@ -53,7 +53,7 @@ asm
   :group 'languages)
 
 (defcustom asm-comment-char ?\;
-  "The comment-start character assumed by Asm mode."
+  "The `comment-start' character assumed by Asm mode."
   :type 'character
   :group 'asm)
 
@@ -187,14 +187,13 @@ asm-colon
       (delete-horizontal-space)
       (tab-to-tab-stop))))
 
-;; Obsolete since Emacs-22.1.
-(defalias 'asm-newline 'newline-and-indent)
+(define-obsolete-function-alias 'asm-newline 'newline-and-indent "27.1")
 
 (defun asm-comment ()
   "Convert an empty comment to a `larger' kind, or start a new one.
 These are the known comment classes:
 
-   1 -- comment to the right of the code (at the comment-column)
+   1 -- comment to the right of the code (at the `comment-column')
    2 -- comment on its own line, indented like code
    3 -- comment on its own line, beginning at the left-most column.
 
-- 
2.11.0


  reply	other threads:[~2019-07-07 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-07 14:44 bug#36540: [PATCH] Small cleanups in asm-mode.el Stefan Kangas
2019-07-07 14:47 ` Stefan Kangas [this message]
2019-07-10 14:02   ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmk7E44tZstxU7KEp0eArK7hjh+fExKLQjsGibA7964nbA@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=36540@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).