From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Wed, 02 Jun 2021 08:54:50 +0200 Message-ID: <87wnrc7o3p.fsf@gnus.org> References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22871"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11301@debbugs.gnu.org, monnier@iro.umontreal.ca To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 02 08:56:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loKnW-0005Xm-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 08:56:14 +0200 Original-Received: from localhost ([::1]:48186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loKnV-00016u-Go for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 02:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loKnK-00016W-BF for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 02:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loKnK-0002TF-3c for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 02:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loKnK-0004Fg-2V for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 02:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 06:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11301 X-GNU-PR-Package: emacs Original-Received: via spool by 11301-submit@debbugs.gnu.org id=B11301.162261690516240 (code B ref 11301); Wed, 02 Jun 2021 06:56:02 +0000 Original-Received: (at 11301) by debbugs.gnu.org; 2 Jun 2021 06:55:05 +0000 Original-Received: from localhost ([127.0.0.1]:38526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loKmP-0004Ds-6m for submit@debbugs.gnu.org; Wed, 02 Jun 2021 02:55:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loKmN-0004DJ-0a for 11301@debbugs.gnu.org; Wed, 02 Jun 2021 02:55:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KUwWSBkYzHPvHuNrFdZ+Rlw44NGn6Q2i7LV2BtDiIGY=; b=jUo9HPxhh8z2XNsPSl4bcR58f6 IF5pBbTO0uHIXdVlOTcOffx02NRmTxFIoUHxGdusd4+HiQgVpjDksL1UDh2WRadPkUfQ61plTvDFS fuZBbpkwlVYcLh+Gw9B2WD1lVIXCek5ySTODuNf/hzlhQD9M3OcePegQyPk3Z435ex28=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loKmD-0002uo-96; Wed, 02 Jun 2021 08:54:55 +0200 X-Now-Playing: Ana Roxanne's _Ana Roxanne_: "Slowness" In-Reply-To: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> (Drew Adams's message of "Sat, 21 Apr 2012 10:18:34 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207831 Archived-At: "Drew Adams" writes: > My suggestion is for `define-minor-mode' - and perhaps other > mode-defining macros - to do likewise. `define-minor-mode' apparently > uses the :group keyword only for defining the user options it defines. I've tried following the logic and history of the :group keyword in easy-mmode.el, and I'm not sure how that's supposed to work any more. `define-minor-mode' used to document taking a :group keyword, but that's been removed in: commit 6e7736ac5f42e2f1b17aacdfb2a60d8bb951d038 Author: Stefan Monnier AuthorDate: Wed Sep 9 13:29:59 2020 -0400 The only remaining mention is in this example: For example, you could write (define-minor-mode foo-mode \"If enabled, foo on you!\" :lighter \" Foo\" :require \\='foo :global t :group \\='hassle :version \"27.5\" ...BODY CODE...) `define-globalized-minor-mode' does mention it, though, and passes it on to `define-minor-mode'... which doesn't use it? I've added Stefan to the CCs; I'm sure he knows what's going on. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no