From: Michael Heerdegen <michael_heerdegen@web.de>
To: 64232@debbugs.gnu.org
Cc: eliz@gnu.org, zack@owlfolio.org, monnier@iro.umontreal.ca
Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’
Date: Thu, 29 Jun 2023 05:43:13 +0200 [thread overview]
Message-ID: <87wmznhr1q.fsf@web.de> (raw)
In-Reply-To: <jwvfs6bg11p.fsf-monnier+emacs@gnu.org> (Stefan Monnier via's message of "Wed, 28 Jun 2023 09:41:32 -0400")
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> > --- a/lisp/emacs-lisp/bytecomp.el
> > +++ b/lisp/emacs-lisp/bytecomp.el
> > @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment
> > (let ((byte-compile-unresolved-functions
> > byte-compile-unresolved-functions)
> > (byte-compile-new-defuns
> > - byte-compile-new-defuns))
> > + byte-compile-new-defuns)
> > + (byte-compile-noruntime-functions
> > + byte-compile-noruntime-functions))
> > (setf result
> > (byte-compile-eval
> > (byte-run-strip-symbol-positions
>
> Hmm... this doesn't look right: one of the main purpose of
> `byte-compile-eval` is (beside calling `eval`) to populate
> `byte-compile-noruntime-functions`, so if you let-bind it around the
> call, it's like calling `eval` and we can just get rid of
> `byte-compile-noruntime-functions` altogether.
Hmm - ok.
> The "natural" place to put the let-binding would be in
> `byte-compile-close-variables` (assuming it still fixes the bug).
Seems it does not. Maybe we should try to understand what is happening
first.
Part of the problem is the dependency
check-declare -> compile -> comint -> ansi-color
so the compiler might think we are `requiring' ansi-color (which the
compiled file uses) inside our `eval-when-compile' by purpose.
The warning is the same as when one did just
#+begin_src emacs-lisp
(eval-when-compile
(require 'ansi-color))
#+end_src
When removing that `eval-when-compile' the warning message goes away.
So the compiler warns stricter when something is required inside
`eval-when-compile', even if there would be no warning at all without
it.
Michael.
next prev parent reply other threads:[~2023-06-29 3:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 19:56 bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’ Zack Weinberg
2023-06-24 11:49 ` Eli Zaretskii
2023-06-24 15:15 ` Zack Weinberg
2023-06-28 2:10 ` Michael Heerdegen
2023-06-28 13:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29 3:43 ` Michael Heerdegen [this message]
2023-06-29 4:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-30 4:02 ` Michael Heerdegen
2023-06-30 6:00 ` Eli Zaretskii
2023-07-06 6:43 ` Eli Zaretskii
2023-07-07 16:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-07 18:15 ` Eli Zaretskii
2023-06-29 4:17 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmznhr1q.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=64232@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).