From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?UTF-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= Date: Thu, 29 Jun 2023 05:43:13 +0200 Message-ID: <87wmznhr1q.fsf@web.de> References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12518"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eliz@gnu.org, zack@owlfolio.org, monnier@iro.umontreal.ca To: 64232@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 05:44:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEiZz-000339-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 05:44:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEiZi-0001cQ-By; Wed, 28 Jun 2023 23:44:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEiZg-0001a5-44 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 23:44:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEiZf-00022G-5D for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 23:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEiZe-0006pQ-UY for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 23:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64232 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Eli Zaretskii , Zack Weinberg , 64232@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.168801022126211 (code B ref -1); Thu, 29 Jun 2023 03:44:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jun 2023 03:43:41 +0000 Original-Received: from localhost ([127.0.0.1]:51930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEiZI-0006og-8q for submit@debbugs.gnu.org; Wed, 28 Jun 2023 23:43:40 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEiZD-0006oW-3M for submit@debbugs.gnu.org; Wed, 28 Jun 2023 23:43:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEiZC-000187-Sj for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 23:43:34 -0400 Original-Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEiZB-0001zf-4q; Wed, 28 Jun 2023 23:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688010195; x=1688614995; i=michael_heerdegen@web.de; bh=4AtcxjBwZismi8EDOmvPWvii+QztFuHO/bCyl1ZcHKc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XZR5Z9MK1HpwU5Gl/9UbRkYIUiTy8/78tBWaUM/9XuNCG1J/PtySS+CGiuyz8i3Kv+7Nu4P 7sYt4NiQ6uaGagPl2L+iCOLduAOjROUNgVT7kWIOimmPk4QaOcXXk/mSCuQ9ZQBapcrAQO+NH fzDmeLXlJNfjios/S4zhpWkr8jfmDmwV723UAVwti5vS4YdfvOHRWXa4UNh1Z+N3OuC6Y6BZw 9Zy/eKjLosWg2dwqTVikL8HDOFlujq6vfuWUYwN1c8wUWYrB4u8TzOOnj07PSMPgMiIdGV+5Y hb9aDq7YMQ2mAMSuoqaXsDk/FWpWscQ0GORcvB5UDkSSIlleufMw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Vop-1q1XAQ2Rpx-0143Vg; Thu, 29 Jun 2023 05:43:15 +0200 In-Reply-To: (Stefan Monnier via's message of "Wed, 28 Jun 2023 09:41:32 -0400") X-Provags-ID: V03:K1:tH2G9K7S6rt61bluau//YEFl7Wv4Bj4CdkQ+rb0D8Rzs1jdydIv J7H8Uo16L6jfKQ2EU5zMDY/Tq8mRLK6D/Mg2P2dMrqv6bDPzk221fEdL4o4qmxpq3A6QRPo Xf5uHAyOaGN7wm/43tWBh82LU+tNFlWDTj3m1SZcX2TEWOaEfAY2CDRhPQ7XpN1Si+z1Bfc TutHP6fc3Qs4DGANA0s+w== UI-OutboundReport: notjunk:1;M01:P0:8H+gyDyF+R8=;DL2hsJ6xSoiGieW5TFyJOM54Vov o1Q+n+N0rvF5whEBNOBc1qfPji5MaPYGdlMqCOcloS0Z8741MmjagvSDieDmLxDsLRbn13q2+ kjBgdQeCZ+x3rEXijgzJTek+atgsXpkYHE8j5dM4fYGVsgK5RZHEYNao8T5BXhDMi/S1T/SOa cOcwfADNo4FuO4F2LTL8YutYk4/xCLdxgSEdp0R+1J/GARk/+eY7N8fr8B/LVOKAQZm8Fdq7+ xZZLfsHl4p6wWA/xJFr5pxD1sO3yWT0w3d3B8doOdxpFKxJCKfLtPBliWNdKC58jBq5pEyvsY J4meQKD9PCgz+eM34E527eB4mgM3JYXxo+VS34FcV099gorVcEXWb3FIRglzWCmrsmAZsCCkl e8xrSE1sGsRLXvHNMIcrOc7e0C5tkhA9yL4c5aXWWVDHuGt8+XwFx6+BGb76jBNpX8g+WFI7m FsVVfxU3STmyttqY9sFX/8eW3X5eWRgHN7aS7jjrA7RS3s4ZPGDcB1KNf3Bq3s9FvjfxvLvOr B9/3yxhZQogPKrahwt/yZXyUodtV6kpvLG+/ucO/zl/CO4Bj7BozxoDROWGff7MuSz4fp0QoR r/1f3dHYi9RGAyYBwGzPGJFtWGF5qERVw0Y4KeCF8Bx+shZ5IYDlE7tmuLhLWyzBSNtXex7pl utSAT+ErNsMSHGA6+CfOn4pjgPUagaYiGJA/7N+g0p/JbVvxmBaTul9ei05Nc1XbsCdmCEzxS VjRyYfX/nImNgUtFhLSg6d79K/nBHQo3RaAf5UN5jPbNfsxLsJc98IoxHS8rUCpXGVrVmee/ Received-SPF: pass client-ip=212.227.17.11; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264248 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > --- a/lisp/emacs-lisp/bytecomp.el > > +++ b/lisp/emacs-lisp/bytecomp.el > > @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment > > (let ((byte-compile-unresolved-functions > > byte-compile-unresolved-functions) > > (byte-compile-new-defuns > > - byte-compile-new-defuns)) > > + byte-compile-new-defuns) > > + (byte-compile-noruntime-functions > > + byte-compile-noruntime-functions)) > > (setf result > > (byte-compile-eval > > (byte-run-strip-symbol-positions > > Hmm... this doesn't look right: one of the main purpose of > `byte-compile-eval` is (beside calling `eval`) to populate > `byte-compile-noruntime-functions`, so if you let-bind it around the > call, it's like calling `eval` and we can just get rid of > `byte-compile-noruntime-functions` altogether. Hmm - ok. > The "natural" place to put the let-binding would be in > `byte-compile-close-variables` (assuming it still fixes the bug). Seems it does not. Maybe we should try to understand what is happening first. Part of the problem is the dependency check-declare -> compile -> comint -> ansi-color so the compiler might think we are `requiring' ansi-color (which the compiled file uses) inside our `eval-when-compile' by purpose. The warning is the same as when one did just #+begin_src emacs-lisp (eval-when-compile (require 'ansi-color)) #+end_src When removing that `eval-when-compile' the warning message goes away. So the compiler warns stricter when something is required inside `eval-when-compile', even if there would be no warning at all without it. Michael.