unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: zack@owlfolio.org, 64232@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’
Date: Fri, 30 Jun 2023 09:00:33 +0300	[thread overview]
Message-ID: <83wmzlsd4u.fsf@gnu.org> (raw)
In-Reply-To: <875y751tsz.fsf@web.de> (message from Michael Heerdegen on Fri, 30 Jun 2023 06:02:36 +0200)

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 64232@debbugs.gnu.org,  eliz@gnu.org,  zack@owlfolio.org
> Date: Fri, 30 Jun 2023 06:02:36 +0200
> 
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> > Someone™ should sit down and figure out how to make `bytecomp.el` keep
> > track of those things more reliably/predictably.
> > In the mean time, maybe we can simply tweak `byte-compile-eval` so it
> > never adds to `byte-compile-noruntime-functions` functions which have
> > already been seen/declared during the current compilation?
> >
> >
> > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> > index 99202185d8d..cfec4b3be06 100644
> > --- a/lisp/emacs-lisp/bytecomp.el
> > +++ b/lisp/emacs-lisp/bytecomp.el
> > @@ -1128,7 +1128,8 @@ byte-compile-eval
> >  		     ;; we arguably should add it to b-c-noruntime-functions,
> >                       ;; but it's not clear it's worth the trouble
> >  		     ;; trying to recognize that case.
> > -		     (unless (get f 'function-history)
> > +		     (unless (or (get f 'function-history)
> > +                                 (assq f byte-compile-function-environment))
> >                         (push f byte-compile-noruntime-functions)))))))))))))
> 
> Seems appropriate (and fixes this bug).
> 
> Actually with that patch the situation looks already quite ok'ish to me.

Please install this on master, and thanks.





  reply	other threads:[~2023-06-30  6:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 19:56 bug#64232: 28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’ Zack Weinberg
2023-06-24 11:49 ` Eli Zaretskii
2023-06-24 15:15   ` Zack Weinberg
2023-06-28  2:10     ` Michael Heerdegen
2023-06-28 13:41       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-29  3:43         ` Michael Heerdegen
2023-06-29  4:51           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-30  4:02             ` Michael Heerdegen
2023-06-30  6:00               ` Eli Zaretskii [this message]
2023-07-06  6:43                 ` Eli Zaretskii
2023-07-07 16:10                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-07 18:15                     ` Eli Zaretskii
2023-06-29  4:17 ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wmzlsd4u.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64232@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=zack@owlfolio.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).