From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#31800: suggestion of improvement for sort-numeric-fields function. Date: Wed, 22 Jan 2020 14:44:36 +0100 Message-ID: <87v9p3vc57.fsf@gnus.org> References: <874l3qy517.fsf@mouse.gnus.org> <87v9p5rjhj.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58784"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: SK Kim , 31800@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 22 14:45:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuGJl-000FFY-4X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Jan 2020 14:45:13 +0100 Original-Received: from localhost ([::1]:42368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuGJk-0007N1-6F for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Jan 2020 08:45:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54486) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuGJb-0007Mj-QG for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2020 08:45:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuGJa-0007Uj-MD for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2020 08:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuGJa-0007UM-Id for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2020 08:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iuGJa-000136-GC for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2020 08:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2020 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31800-submit@debbugs.gnu.org id=B31800.15797006883995 (code B ref 31800); Wed, 22 Jan 2020 13:45:02 +0000 Original-Received: (at 31800) by debbugs.gnu.org; 22 Jan 2020 13:44:48 +0000 Original-Received: from localhost ([127.0.0.1]:49231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuGJM-00012M-J3 for submit@debbugs.gnu.org; Wed, 22 Jan 2020 08:44:48 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuGJK-000126-S7 for 31800@debbugs.gnu.org; Wed, 22 Jan 2020 08:44:47 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuGJB-0003ig-Nw; Wed, 22 Jan 2020 14:44:40 +0100 In-Reply-To: <87v9p5rjhj.fsf@marxist.se> (Stefan Kangas's message of "Mon, 20 Jan 2020 20:55:04 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175074 Archived-At: Stefan Kangas writes: > The patch below looks good to me. Does anyone else have an opinion > here, or should I go ahead and commit it to master? [...] >> - (sort-skip-fields field) >> + (unless (string-match-p "^\\s-*$" (thing-at-point 'line)) >> + (sort-skip-fields field)) I don't think this patch makes sense as is -- I think that's a convoluted way of saying `looking-at'? But it makes conceptual sense, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no