From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org
Subject: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers
Date: Wed, 12 May 2021 17:57:14 +0200 [thread overview]
Message-ID: <87v97ogd2d.fsf@gnus.org> (raw)
In-Reply-To: <83im3o2brt.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 18:48:54 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> I tried the code example in that bug report now (with the patch that
>> removes the sanity check), and it did not crash Emacs. So that sanity
>> check no longer seems to be necessary?
>
> Probably because some code somewhere uses save-match-data.
I guess. But we have a case here where the sanity check is definitely
wrong, and we don't have a reproducing case (any more) for the problem
the check is trying to fix... which seems to indicate to me that we
should apply the patch (i.e., remove the buggy sanity check).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-05-12 15:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 4:40 bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Noam Postavsky
2019-05-30 23:03 ` Noam Postavsky
2020-10-02 4:47 ` Lars Ingebrigtsen
2021-05-12 14:35 ` Lars Ingebrigtsen
2021-05-12 14:55 ` Eli Zaretskii
2021-05-12 15:43 ` Lars Ingebrigtsen
2021-05-12 15:48 ` Eli Zaretskii
2021-05-12 15:57 ` Lars Ingebrigtsen [this message]
2021-05-12 16:03 ` Eli Zaretskii
2021-05-13 9:11 ` Lars Ingebrigtsen
2021-05-13 10:14 ` Eli Zaretskii
2021-05-13 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-13 17:09 ` Eli Zaretskii
2021-05-16 13:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v97ogd2d.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=35264@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).