From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, 35264@debbugs.gnu.org
Subject: bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers
Date: Wed, 12 May 2021 17:55:58 +0300 [thread overview]
Message-ID: <83o8dg2e81.fsf@gnu.org> (raw)
In-Reply-To: <8735usj9z9.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 16:35:38 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 12 May 2021 16:35:38 +0200
> Cc: stefan monnier <monnier@iro.umontreal.ca>, 35264@debbugs.gnu.org
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> >> But the modification hook in question did call save-match-data. As far
> >> as I can tell, the problem is that the match-data consists of markers,
> >> whose position gets shifted by deletion of characters. The check for
> >> this error uses simple integers, so there's no way it can account for
> >> this.
> >
> > That does make sense, but removing this (somewhat buggy) sanity check is
> > perhaps a bit scary. Any comments on this?
>
> There were no comments, and the patch no longer applies. I've respun it
> now for Emacs 28, and this fixes the case reported in this bug report
> (which still reproduces in Emacs 28).
>
> Any comments?
What about bug#23869, which triggered the addition of that code?
next prev parent reply other threads:[~2021-05-12 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 4:40 bug#35264: "Match data clobbered by buffer modification hooks" when hooks only shifted match-data's markers Noam Postavsky
2019-05-30 23:03 ` Noam Postavsky
2020-10-02 4:47 ` Lars Ingebrigtsen
2021-05-12 14:35 ` Lars Ingebrigtsen
2021-05-12 14:55 ` Eli Zaretskii [this message]
2021-05-12 15:43 ` Lars Ingebrigtsen
2021-05-12 15:48 ` Eli Zaretskii
2021-05-12 15:57 ` Lars Ingebrigtsen
2021-05-12 16:03 ` Eli Zaretskii
2021-05-13 9:11 ` Lars Ingebrigtsen
2021-05-13 10:14 ` Eli Zaretskii
2021-05-13 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-13 17:09 ` Eli Zaretskii
2021-05-16 13:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8dg2e81.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35264@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).